Differential D8963

luigi: Read meta/export.json instead of relying on stamp files
ClosedPublic
Actions

Authored by vlorentz on Dec 16 2022, 3:10 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDDATASET4c432adf7b21: luigi: Read meta/export.json instead of relying on stamp files

Summary

Stamp files are only useful while building, and not copied to and from S3,
so the check failed after a round-trip through S3.

Diff Detail

Repository

rDDATASET Datasets

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 33308
Build 52206: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 52205: arc lint + arc unit

Event Timeline

vlorentz created this revision.Dec 16 2022, 3:10 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 16 2022, 3:10 PM

Build is green

Patch application report for D8963 (id=32300)

Rebasing onto c717f60fe0...

Current branch diff-target is up to date.

Changes applied before test

commit dab573172c21e67c273ab86122714e35da33465e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Dec 16 15:10:25 2022 +0100

    luigi: Read meta/export.json instead of relying on stamp files
    
    Stamp files are only useful while building, and not copied to and from S3,
    so the check failed after a round-trip through S3.

See https://jenkins.softwareheritage.org/job/DDATASET/job/tests-on-diff/175/ for more details.

Harbormaster completed remote builds in B33255: Diff 32300.Dec 16 2022, 3:12 PM

vlorentz requested review of this revision.Dec 16 2022, 3:12 PM

anlambert accepted this revision.Dec 19 2022, 5:05 PM

This revision is now accepted and ready to land.Dec 19 2022, 5:05 PM

rebase

Build is green

Patch application report for D8963 (id=32317)

Rebasing onto d391394e53...

Current branch diff-target is up to date.

Changes applied before test

commit 4c432adf7b218ed57d2e1075ba7f63e48e6ab9ca
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Dec 16 15:10:25 2022 +0100

    luigi: Read meta/export.json instead of relying on stamp files
    
    Stamp files are only useful while building, and not copied to and from S3,
    so the check failed after a round-trip through S3.

See https://jenkins.softwareheritage.org/job/DDATASET/job/tests-on-diff/178/ for more details.

Harbormaster completed remote builds in B33308: Diff 32317.Dec 19 2022, 6:24 PM

Closed by commit rDDATASET4c432adf7b21: luigi: Read meta/export.json instead of relying on stamp files (authored by vlorentz). · Explain WhyDec 20 2022, 10:04 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDDATASET4c432adf7b21: luigi: Read meta/export.json instead of relying on stamp files.