Page MenuHomeSoftware Heritage
Differential D8936

cli.add_forge_now: Open `schedule-first-visits` with sensible defaults
ClosedPublic
Actions

Authored by ardumont on Dec 7 2022, 3:19 PM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDSCH1c34e9837faa: cli.add_forge_now: Open `schedule-first-visits` with sensible defaults
Summary

This should ease scheduling the first visits for add-forge-now request.

The following would be enough to fetch and schedule the forge just listed (be it in
production or staging):

swh scheduler add-forge-now \
  schedule-first-visits \
    --visit-type git \
    (--visit-type svn \ # if a lister lists multiple kinds of visit, we can mention it )
    --lister-name gitea \
    --lister-instance-name git.afpy.org \
    ( --production | --staging )  # to list only enabled | disabled origins

Future diffs will add other subcommand to that new module.

Related to https://gitlab.softwareheritage.org/infra/sysadm-environment/-/issues/4674

Test Plan

Common function extracted and tests added

Diff Detail

Repository
rDSCH Scheduling utilities
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 33165
Build 51993: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 51992: arc lint + arc unit

Event Timeline

ardumont created this revision.Dec 7 2022, 3:19 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 7 2022, 3:19 PM
ardumont edited the summary of this revision. (Show Details)Dec 7 2022, 3:20 PM
swh-public-ci added a comment.Dec 7 2022, 3:26 PM

Build is green

Patch application report for D8936 (id=32202)

Rebasing onto e2878b5f65...

Current branch diff-target is up to date.
Changes applied before test
commit 41163465a998d9b57e0f9fee2231745cfa4a9dbc
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Dec 7 15:14:32 2022 +0100

    cli.origin: Open `swh scheduler add-forge-now` with sensible defaults
    
    Related to https://gitlab.softwareheritage.org/infra/sysadm-environment/-/issues/4674

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/578/ for more details.

Harbormaster completed remote builds in B33156: Diff 32202.Dec 7 2022, 3:26 PM
ardumont requested review of this revision.Dec 7 2022, 3:26 PM
ardumont retitled this revision from cli.origin: Open `swh scheduler add-forge-now` with sensible defaults to cli.add_forge_now: Open `schedule-first-visits` with sensible defaultsg.Dec 7 2022, 4:15 PM
ardumont edited the summary of this revision. (Show Details)
ardumont updated this revision to Diff 32208.Dec 7 2022, 4:15 PM

Adapt according to irc sysadm discussion

ardumont edited the summary of this revision. (Show Details)Dec 7 2022, 4:15 PM
ardumont retitled this revision from cli.add_forge_now: Open `schedule-first-visits` with sensible defaultsg to cli.add_forge_now: Open `schedule-first-visits` with sensible defaults.
swh-public-ci added a comment.Dec 7 2022, 4:21 PM

Build is green

Patch application report for D8936 (id=32208)

Rebasing onto e2878b5f65...

Current branch diff-target is up to date.
Changes applied before test
commit 40b1fb9daf2df4706b96bcffbce91b10ba9bc39f
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Dec 7 15:14:32 2022 +0100

    cli.add_forge_now: Open `schedule-first-visits` with sensible defaults
    
    This should ease scheduling the first visits for add-forge-now request.
    
    The following would be enough to fetch and schedule the forge just listed (be it in
    production or staging):
swh scheduler add-forge-now \
  schedule-first-visits \
    --visit-type git \
    (--visit-type svn \ # if a lister lists multiple kinds of visit, we can mention it )
    --lister-name gitea \
    --lister-instance-name git.afpy.org \
    ( --production | --staging )  # to list only enabled | disabled origins
```

Related to https://gitlab.softwareheritage.org/infra/sysadm-environment/-/issues/4674
See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/579/ for more details.
Harbormaster completed remote builds in B33162: Diff 32208.Dec 7 2022, 4:21 PM
olasd accepted this revision.Dec 7 2022, 4:38 PM
olasd added a subscriber: olasd.

A couple of suggestions inline, but lgtm otherwise, thanks!

swh/scheduler/tests/test_cli_add_forge_now.py
59
63
This revision is now accepted and ready to land.Dec 7 2022, 4:38 PM
ardumont added a comment.EditedDec 7 2022, 4:43 PM

d'oh at your suggestions, you're totally right!

ardumont updated this revision to Diff 32211.Dec 7 2022, 4:44 PM

Adapt according to suggestion

swh-public-ci added a comment.Dec 7 2022, 4:49 PM

Build is green

Patch application report for D8936 (id=32211)

Rebasing onto e2878b5f65...

Current branch diff-target is up to date.
Changes applied before test
commit 1c34e9837faa1b955aa3ec98b8edc85e772f8f53
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Wed Dec 7 15:14:32 2022 +0100

    cli.add_forge_now: Open `schedule-first-visits` with sensible defaults
    
    This should ease scheduling the first visits for add-forge-now request.
    
    The following would be enough to fetch and schedule the forge just listed (be it in
    production or staging):
swh scheduler add-forge-now \
  schedule-first-visits \
    --visit-type git \
    (--visit-type svn \ # if a lister lists multiple kinds of visit, we can mention it )
    --lister-name gitea \
    --lister-instance-name git.afpy.org \
    ( --production | --staging )  # to list only enabled | disabled origins
```

Related to https://gitlab.softwareheritage.org/infra/sysadm-environment/-/issues/4674
See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/580/ for more details.
Harbormaster completed remote builds in B33165: Diff 32211.Dec 7 2022, 4:49 PM
Closed by commit rDSCH1c34e9837faa: cli.add_forge_now: Open `schedule-first-visits` with sensible defaults (authored by ardumont). · Explain WhyDec 7 2022, 4:54 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDSCH1c34e9837faa: cli.add_forge_now: Open `schedule-first-visits` with sensible defaults.
ardumont mentioned this in D8929: sysadm: Add a "how to process add-forge-now requests".Dec 8 2022, 5:20 PM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
scheduler/
cli/
91 lines93%
Loading...
52 lines88%
Loading...
79 lines96%
Loading...
tests/
88 lines100%
Loading...
8 lines100%
Loading...

Diff 32211

View Options

swh/scheduler/cli/add_forge_now.py

Loading...
View Options

swh/scheduler/cli/origin.py

Loading...
View Options

swh/scheduler/cli/utils.py

Loading...
View Options

swh/scheduler/tests/test_cli_add_forge_now.py

Loading...
View Options

swh/scheduler/tests/test_cli_origin.py

Loading...
About · Developer information · Legal