Differential D8859

Rename the content attribute fileType to mimeType in the schema
ClosedPublic
Actions

Authored by jayeshv on Nov 21 2022, 12:05 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDGQL8b1d5ee3d673: Rename the content attribute fileType to mimeType in the schema

Diff Detail

Repository

rDGQL GraphQL API

Branch

file-to-mime

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32860
Build 51494: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 51493: arc lint + arc unit

Event Timeline

jayeshv created this revision.Nov 21 2022, 12:05 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 21 2022, 12:05 PM

Build is green

Patch application report for D8859 (id=31932)

Rebasing onto 7522a848fa...

Current branch diff-target is up to date.

Changes applied before test

commit ce16320a21db98769a52363041f393b33a78eb0e
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 21 12:04:05 2022 +0100

    Rename the content attribute fileType to mimeType in the schema

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/230/ for more details.

Harbormaster completed remote builds in B32860: Diff 31932.Nov 21 2022, 12:07 PM

jayeshv requested review of this revision.Nov 21 2022, 12:07 PM

that's not the actual MIME type though; encoding is only an optional part of it

In D8859#230346, @vlorentz wrote:

that's not the actual MIME type though; encoding is only an optional part of it

ok. what would be a good name for this field then, fileType itself?

What about this?

mimeType {
  mimeType
  encoding
}

oh you already support that, alright then

This revision is now accepted and ready to land.Nov 21 2022, 1:53 PM

In D8859#230390, @vlorentz wrote:

oh you already support that, alright then

Yup. the real indexer integration is pending though

rebase

Build is green

Patch application report for D8859 (id=31939)

Rebasing onto a4a3d1dd58...

Current branch diff-target is up to date.

Changes applied before test

commit 8b1d5ee3d673da1c6b77e4990a05f9898fe1195a
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 21 12:04:05 2022 +0100

    Rename the content attribute fileType to mimeType in the schema

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/232/ for more details.

Harbormaster completed remote builds in B32867: Diff 31939.Nov 21 2022, 2:01 PM

Closed by commit rDGQL8b1d5ee3d673: Rename the content attribute fileType to mimeType in the schema (authored by jayeshv). · Explain WhyNov 21 2022, 2:01 PM

This revision was automatically updated to reflect the committed changes.

jayeshv added a commit: rDGQL8b1d5ee3d673: Rename the content attribute fileType to mimeType in the schema.