Page MenuHomeSoftware Heritage

Rename the content attribute fileType to mimeType in the schema
ClosedPublic

Authored by jayeshv on Nov 21 2022, 12:05 PM.

Diff Detail

Repository
rDGQL GraphQL API
Branch
file-to-mime
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 32860
Build 51494: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 51493: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D8859 (id=31932)

Rebasing onto 7522a848fa...

Current branch diff-target is up to date.
Changes applied before test
commit ce16320a21db98769a52363041f393b33a78eb0e
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 21 12:04:05 2022 +0100

    Rename the content attribute fileType to mimeType in the schema

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/230/ for more details.

that's not the actual MIME type though; encoding is only an optional part of it

that's not the actual MIME type though; encoding is only an optional part of it

ok. what would be a good name for this field then, fileType itself?

What about this?

mimeType {
  mimeType
  encoding
}

oh you already support that, alright then

This revision is now accepted and ready to land.Nov 21 2022, 1:53 PM

oh you already support that, alright then

Yup. the real indexer integration is pending though

Build is green

Patch application report for D8859 (id=31939)

Rebasing onto a4a3d1dd58...

Current branch diff-target is up to date.
Changes applied before test
commit 8b1d5ee3d673da1c6b77e4990a05f9898fe1195a
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Mon Nov 21 12:04:05 2022 +0100

    Rename the content attribute fileType to mimeType in the schema

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/232/ for more details.