Differential D8754

Fix documentation build
ClosedPublic
Actions

Authored by vlorentz on Oct 23 2022, 5:40 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDSTO82ad28bb29f5: Fix documentation build

Summary

It was broken by D8740
because the conditional import prevents sphinx from detecting
where the class is imported from.

Additionally, this attribute should not be on the interface,
because proxies do not have it, but they are expected to have
that interface.

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32508
Build 50911: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 50910: arc lint + arc unit

Event Timeline

vlorentz created this revision.Oct 23 2022, 5:40 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 23 2022, 5:40 PM

Build is green

Patch application report for D8754 (id=31554)

Rebasing onto 0e8da810ac...

Current branch diff-target is up to date.

Changes applied before test

commit 82ad28bb29f52424b89a12fbaba286fce1c13c1e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Sun Oct 23 17:39:30 2022 +0200

    Fix documentation build
    
    It was broken by 0e8da810ac962b79dda18d9cfe9f3c7ea4f9de52
    because the conditional import prevents sphinx from detecting
    where the class is imported from.
    
    Additionally, this attribute should not be on the interface,
    because proxies do not have it, but they are expected to have
    that interface.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1689/ for more details.

Harbormaster completed remote builds in B32508: Diff 31554.Oct 23 2022, 5:54 PM

vlorentz requested review of this revision.Oct 23 2022, 5:54 PM

ardumont accepted this revision.Oct 24 2022, 10:39 AM

This revision is now accepted and ready to land.Oct 24 2022, 10:39 AM

Closed by commit rDSTO82ad28bb29f5: Fix documentation build (authored by vlorentz). · Explain WhyOct 24 2022, 12:54 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTO82ad28bb29f5: Fix documentation build.