Differential D8677

loader: Raise NotFound for missing CVS module when using pserver or ssh
ClosedPublic
Actions

Authored by anlambert on Oct 13 2022, 4:23 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

Restricted Maniphest Task

Commits

rDLDCVS965c3de498f5: loader: Raise NotFound for missing CVS module when using pserver or ssh

Summary

That case was handled when using rsync protocol but not when using pserver
or ssh protocol.

Closes T4631

Diff Detail

Repository

rDLDCVS CVS Loader

Branch

pserver-ssh-module-not-found

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32301
Build 50596: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 50595: arc lint + arc unit

Event Timeline

anlambert created this revision.Oct 13 2022, 4:23 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 13 2022, 4:23 PM

Build is green

Patch application report for D8677 (id=31336)

Rebasing onto 83fae9c7b3...

Current branch diff-target is up to date.

Changes applied before test

commit b4ccf0e84feff4feece907ae363d6599a748bcdf
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Oct 13 16:20:59 2022 +0200

    loader: Raise NotFound for missing CVS module when using pserver or ssh
    
    That case was handled when using rsync protocol but not when using pserver
    or ssh protocol.
    
    Closes T4631

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/127/ for more details.

Harbormaster completed remote builds in B32284: Diff 31336.Oct 13 2022, 4:26 PM

anlambert requested review of this revision.Oct 13 2022, 4:26 PM

vlorentz accepted this revision.Oct 13 2022, 6:40 PM

This revision is now accepted and ready to land.Oct 13 2022, 6:40 PM

Rebase

Build is green

Patch application report for D8677 (id=31353)

Rebasing onto 356dfa27f7...

Current branch diff-target is up to date.

Changes applied before test

commit 965c3de498f5a52b1de5e319df087f14e17ea469
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Oct 13 16:20:59 2022 +0200

    loader: Raise NotFound for missing CVS module when using pserver or ssh
    
    That case was handled when using rsync protocol but not when using pserver
    or ssh protocol.
    
    Closes T4631

See https://jenkins.softwareheritage.org/job/DLDCVS/job/tests-on-diff/130/ for more details.

Harbormaster completed remote builds in B32301: Diff 31353.Oct 13 2022, 7:30 PM

Closed by commit rDLDCVS965c3de498f5: loader: Raise NotFound for missing CVS module when using pserver or ssh (authored by anlambert). · Explain WhyOct 13 2022, 7:31 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDCVS965c3de498f5: loader: Raise NotFound for missing CVS module when using pserver or ssh.