tarball: Fix also directory permissions in normalize_permissions
ClosedPublic
Actions

Authored by anlambert on Oct 11 2022, 5:14 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDCORE6012be54994c: tarball: Fix also directory permissions in normalize_permissions

Summary

It exist cases when an uncompressed tarball has directories without
any traversal or read permissions so ensure to also fix directory
permissions in normalize_permissions function.

I spotted that issue while testing the CPAN loader in docker.
It is also happening when attempting to load some PyPI and Maven packages.
(see Sentry issues below).

Fixes SWH-LOADER-CORE-1AZ and SWH-LOADER-CORE-ZW

Diff Detail

Repository

rDCORE Foundations and core functionalities

Branch

tarball-normalize-permissions-fix-also-dirs

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 32227
Build 50477: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 50476: arc lint + arc unit

Event Timeline

anlambert created this revision.Oct 11 2022, 5:14 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptOct 11 2022, 5:14 PM

Build is green

Patch application report for D8660 (id=31276)

Rebasing onto be9403c676...

Current branch diff-target is up to date.

Changes applied before test

commit 3d42643e4e412875e14739d4cc5841d8accdc33f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 11 17:09:26 2022 +0200

    tarball: Fix also directory permissions in normalize_permissions
    
    It exist cases when an uncompressed tarball has directories without
    any traversal or read permissions so ensure to also fix directory
    permissions in normalize_permissions function.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/478/ for more details.

Harbormaster completed remote builds in B32227: Diff 31276.Oct 11 2022, 5:16 PM

anlambert requested review of this revision.Oct 11 2022, 5:16 PM

anlambert edited the summary of this revision. (Show Details)Oct 11 2022, 5:44 PM

vlorentz accepted this revision.Oct 12 2022, 9:40 AM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/core/tarball.py
182–183	for all dirs but the root, your code chmods when `dirpath` is their parent , so there is no need to chmod again when `dirpath` is themselves

This revision is now accepted and ready to land.Oct 12 2022, 9:40 AM

Address @vlorentz comment

Build is green

Patch application report for D8660 (id=31289)

Rebasing onto be9403c676...

Current branch diff-target is up to date.

Changes applied before test

commit 6012be54994c8e48f8cc105a27bc89f2cc249941
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Oct 11 17:09:26 2022 +0200

    tarball: Fix also directory permissions in normalize_permissions
    
    It exist cases when an uncompressed tarball has directories without
    any traversal or read permissions so ensure to also fix directory
    permissions in normalize_permissions function.

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/481/ for more details.

Harbormaster completed remote builds in B32240: Diff 31289.Oct 12 2022, 11:28 AM

Closed by commit rDCORE6012be54994c: tarball: Fix also directory permissions in normalize_permissions (authored by anlambert). · Explain WhyOct 12 2022, 11:30 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDCORE6012be54994c: tarball: Fix also directory permissions in normalize_permissions.