Differential D8585

svn: Add support to basic subversion authentication in SvnRepo
ClosedPublic
Actions

Authored by anlambert on Sep 30 2022, 2:13 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDLDSVN8e735c953ba5: svn: Add support to basic subversion authentication in SvnRepo

Summary

Some subversion servers in the wild disabled anonymous access and require
to authenticate using a read only user account, typically with credentials
anonymous/anonymous.

So add support for basic authentication in the subversion loader, credentials
must be provided in the repository URL as with basic HTTP authentication.

Such repository has been submitted to Save Code Now service: https://anonymous@svn.cryptool.org/CrypTool1/

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Branch

svn-add-basic-auth-support

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31964
Build 50032: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 50031: arc lint + arc unit

Event Timeline

anlambert created this revision.Sep 30 2022, 2:13 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 30 2022, 2:13 PM

Build is green

Patch application report for D8585 (id=30990)

Rebasing onto 651e2964ee...

Current branch diff-target is up to date.

Changes applied before test

commit 2247374a63c8437c2fc40a0d3ac0eda8f2bae7a6
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Sep 30 13:25:05 2022 +0200

    svn: Add support to basic subversion authentication in SvnRepo
    
    Some subversion servers in the wild disabled anonymous access and require
    to authenticate using a read only user account, typically with credentials
    anonymous/anonymous.
    
    So add support for basic authentication in the subversion loader, credentials
    must be provided in the repository URL as with basic HTTP authentication.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/334/ for more details.

Harbormaster completed remote builds in B31960: Diff 30990.Sep 30 2022, 2:17 PM

anlambert requested review of this revision.Sep 30 2022, 2:17 PM

thx

swh/loader/svn/loader.py
675–680
swh/loader/svn/tests/test_loader.py
2134–2150	add some indent to the string's content, since you're already using textwrap

This revision is now accepted and ready to land.Sep 30 2022, 2:30 PM

Address @vlorentz comments.

Build is green

Patch application report for D8585 (id=30994)

Rebasing onto 651e2964ee...

Current branch diff-target is up to date.

Changes applied before test

commit 8e735c953ba594373dbcbed407ff1c2204ee8866
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Sep 30 13:25:05 2022 +0200

    svn: Add support to basic subversion authentication in SvnRepo
    
    Some subversion servers in the wild disabled anonymous access and require
    to authenticate using a read only user account, typically with credentials
    anonymous/anonymous.
    
    So add support for basic authentication in the subversion loader, credentials
    must be provided in the repository URL as with basic HTTP authentication.

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/335/ for more details.

Harbormaster completed remote builds in B31964: Diff 30994.Sep 30 2022, 2:41 PM

Closed by commit rDLDSVN8e735c953ba5: svn: Add support to basic subversion authentication in SvnRepo (authored by anlambert). · Explain WhySep 30 2022, 4:47 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDLDSVN8e735c953ba5: svn: Add support to basic subversion authentication in SvnRepo.