Differential D8563

retry: Do not retry on SystemExit exceptions
ClosedPublic
Actions

Authored by vlorentz on Sep 28 2022, 1:27 PM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDSTO87d3f0d7b471: retry: Do not retry on SystemExit exceptions

Summary

It prevents process shutdown (unless the user presses Ctrl-C
several times in a row)

Diff Detail

Repository

rDSTO Storage manager

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31857
Build 49855: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 49854: arc lint + arc unit

Event Timeline

vlorentz created this revision.Sep 28 2022, 1:27 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 28 2022, 1:27 PM

Build is green

Patch application report for D8563 (id=30886)

Rebasing onto 7da7067af9...

Current branch diff-target is up to date.

Changes applied before test

commit 87d3f0d7b4718b70ad15b21ffc1ccdbc834db951
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Sep 28 13:27:05 2022 +0200

    retry: Do not retry on SystemExit exceptions
    
    It prevents process shutdown (unless the user presses Ctrl-C
    several times in a row)

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1667/ for more details.

Harbormaster completed remote builds in B31857: Diff 30886.Sep 28 2022, 1:42 PM

vlorentz requested review of this revision.Sep 28 2022, 1:42 PM

anlambert accepted this revision.Sep 28 2022, 3:47 PM

This revision is now accepted and ready to land.Sep 28 2022, 3:47 PM

Closed by commit rDSTO87d3f0d7b471: retry: Do not retry on SystemExit exceptions (authored by vlorentz). · Explain WhySep 28 2022, 6:05 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSTO87d3f0d7b471: retry: Do not retry on SystemExit exceptions.