Page MenuHomeSoftware Heritage
Differential D8531

Puppet: Lister for Puppet modules
ClosedPublic
Actions

Authored by franckbret on Sep 26 2022, 11:29 AM.

Details

Reviewers
vlorentz
anlambert
Group Reviewers
Reviewers
Maniphest Tasks
T4519: Create a Puppet Forge lister
Commits
rDLScd596eb2b46d: Puppet: Lister for Puppet modules
Summary

The puppet lister retrieves origins from from https://forge.puppet.com/modules

Related T4519

Diff Detail

Repository
rDLS Listers
Branch
puppet
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 31768
Build 49707: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 49706: arc lint + arc unit

Event Timeline

franckbret created this revision.Sep 26 2022, 11:29 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptSep 26 2022, 11:29 AM
swh-public-ci added a comment.Sep 26 2022, 11:33 AM

Build has FAILED

Patch application report for D8531 (id=30742)

Rebasing onto 9b3e565cf7...

Current branch diff-target is up to date.
Changes applied before test
commit 83d6cd041cfe094b8116296ca7352b98edddd255
Author: Franck Bret <franck.bret@octobus.net>
Date:   Mon Sep 26 11:25:23 2022 +0200

    Puppet: Lister for Puppet modules
    
    The puppet lister retrieves origins from from https://forge.puppet.com/modules
    
    Related T4519

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/687/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/687/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 26 2022, 11:33 AM
Harbormaster failed remote builds in B31719: Diff 30742!
franckbret updated this revision to Diff 30747.Sep 26 2022, 11:39 AM

Fix docstring bad link

swh-public-ci added a comment.Sep 26 2022, 11:40 AM

Build has FAILED

Patch application report for D8531 (id=30747)

Rebasing onto d5c30a3ce3...

First, rewinding head to replay your work on top of it...
Applying: Puppet: Lister for Puppet modules
Changes applied before test
commit 713e20276d36a48bf8d6cbabb2d6d4267568b11f
Author: Franck Bret <franck.bret@octobus.net>
Date:   Mon Sep 26 11:25:23 2022 +0200

    Puppet: Lister for Puppet modules
    
    The puppet lister retrieves origins from from https://forge.puppet.com/modules
    
    Related T4519

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/688/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/688/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 26 2022, 11:40 AM
Harbormaster failed remote builds in B31724: Diff 30747!
franckbret updated this revision to Diff 30748.Sep 26 2022, 12:01 PM

Make use of http_retry instead of throttling_retry decorator after D8519

swh-public-ci added a comment.Sep 26 2022, 12:06 PM

Build is green

Patch application report for D8531 (id=30748)

Rebasing onto d5c30a3ce3...

Current branch diff-target is up to date.
Changes applied before test
commit 5dcdcb7969e0de717d5792620143e35da4cc78d2
Author: Franck Bret <franck.bret@octobus.net>
Date:   Mon Sep 26 11:25:23 2022 +0200

    Puppet: Lister for Puppet modules
    
    The puppet lister retrieves origins from from https://forge.puppet.com/modules
    
    Related T4519

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/689/ for more details.

Harbormaster completed remote builds in B31725: Diff 30748.Sep 26 2022, 12:06 PM
franckbret requested review of this revision.Sep 26 2022, 12:06 PM
vlorentz requested changes to this revision.Sep 26 2022, 2:26 PM
vlorentz added a subscriber: vlorentz.

Thanks, looks good.

A few requests below, though:

Please trim the large text blobs from the test files, it's not useful to keep them verbatim

swh/lister/puppet/__init__.py
12–13

Let's keep it simple :)

29–30
47–48
swh/lister/puppet/lister.py
23–27

reuse the value defined in in pattern.py

34
84–86

to make it clickable

104

lol, the Puppet Forge documentation advertises this format as ISO 8601

*head desk*

This revision now requires changes to proceed.Sep 26 2022, 2:26 PM
franckbret updated this revision to Diff 30791.Sep 26 2022, 6:38 PM
franckbret marked 7 inline comments as done.

Make use of self.http_request as introduced by D8520

Update documentation (typos, rephrase)

swh-public-ci added a comment.Sep 26 2022, 6:43 PM

Build is green

Patch application report for D8531 (id=30791)

Rebasing onto fd1a4244a0...

Current branch diff-target is up to date.
Changes applied before test
commit f242ff0ead88c1854f0b803466ec08777220ab8c
Author: Franck Bret <franck.bret@octobus.net>
Date:   Mon Sep 26 11:25:23 2022 +0200

    Puppet: Lister for Puppet modules
    
    The puppet lister retrieves origins from from https://forge.puppet.com/modules
    
    Related T4519

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/701/ for more details.

Harbormaster completed remote builds in B31768: Diff 30791.Sep 26 2022, 6:43 PM
franckbret updated this revision to Diff 30792.Sep 26 2022, 6:44 PM

typo

franckbret added inline comments.Sep 26 2022, 6:47 PM
swh/lister/puppet/lister.py
23–27

I've change code to use self.http_request instead.

104

lol, the Puppet Forge documentation advertises this format as ISO 8601

*head desk*

yup

swh-public-ci added a comment.Sep 26 2022, 6:49 PM

Build has FAILED

Patch application report for D8531 (id=30792)

Rebasing onto fd1a4244a0...

Current branch diff-target is up to date.
Changes applied before test
commit 366430878fdd7f34794279e9be2522ed24fe89ae
Author: Franck Bret <franck.bret@octobus.net>
Date:   Mon Sep 26 11:25:23 2022 +0200

    Puppet: Lister for Puppet modules
    
    The puppet lister retrieves origins from from https://forge.puppet.com/modules
    
    Related T4519

Link to build: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/702/
See console output for more information: https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/702/console

Harbormaster failed remote builds in B31769: Diff 30792!Sep 26 2022, 6:49 PM
franckbret updated this revision to Diff 30794.Sep 26 2022, 6:53 PM

Sphinx fix

swh-public-ci added a comment.Sep 26 2022, 6:58 PM

Build is green

Patch application report for D8531 (id=30794)

Rebasing onto fd1a4244a0...

Current branch diff-target is up to date.
Changes applied before test
commit b0c63d133ab034ace9057ed0c7b001736a835c9c
Author: Franck Bret <franck.bret@octobus.net>
Date:   Mon Sep 26 11:25:23 2022 +0200

    Puppet: Lister for Puppet modules
    
    The puppet lister retrieves origins from from https://forge.puppet.com/modules
    
    Related T4519

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/703/ for more details.

Harbormaster completed remote builds in B31771: Diff 30794.Sep 26 2022, 6:58 PM
vlorentz accepted this revision.Sep 27 2022, 11:08 AM
This revision is now accepted and ready to land.Sep 27 2022, 11:08 AM
anlambert accepted this revision.Sep 27 2022, 11:23 AM
franckbret updated this revision to Diff 30829.Sep 27 2022, 2:45 PM

rebase

This revision was landed with ongoing or failed builds.Sep 27 2022, 2:46 PM
Closed by commit rDLScd596eb2b46d: Puppet: Lister for Puppet modules (authored by franckbret). · Explain Why
This revision was automatically updated to reflect the committed changes.
franckbret added a commit: rDLScd596eb2b46d: Puppet: Lister for Puppet modules.
swh-public-ci added a comment.Sep 27 2022, 2:51 PM

Build is green

Patch application report for D8531 (id=30829)

Rebasing onto a4aec3894e...

Current branch diff-target is up to date.
Changes applied before test
commit cd596eb2b46ddf21482f6b85b0b92b84b9988774
Author: Franck Bret <franck.bret@octobus.net>
Date:   Mon Sep 26 11:25:23 2022 +0200

    Puppet: Lister for Puppet modules
    
    The puppet lister retrieves origins from from https://forge.puppet.com/modules
    
    Related T4519

See https://jenkins.softwareheritage.org/job/DLS/job/tests-on-diff/709/ for more details.

Harbormaster completed remote builds in B31805: Diff 30829.Sep 27 2022, 2:52 PM
franckbret mentioned this in T4519: Create a Puppet Forge lister.Sep 29 2022, 2:46 PM
bchauvet added a task: T4519: Create a Puppet Forge lister.Sep 30 2022, 9:53 AM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
1 line--
swh/
lister/
puppet/
101 lines84%
Loading...
98 lines100%
Loading...
19 lines100%
Loading...
tests/
--
data/
https_forgeapi.puppet.com/
391 lines--
190 lines--
79 lines100%
Loading...
31 lines100%
Loading...

Diff 30791

View Options

setup.py

Loading...
View Options

swh/lister/puppet/__init__.py

Loading...
View Options

swh/lister/puppet/lister.py

Loading...
View Options

swh/lister/puppet/tasks.py

Loading...
View Options

swh/lister/puppet/tests/__init__.py

Loading...
View Options

swh/lister/puppet/tests/data/https_forgeapi.puppet.com/v3_modules,limit=100

Loading...
View Options

swh/lister/puppet/tests/data/https_forgeapi.puppet.com/v3_modules,limit=100,offset=100

Loading...
View Options

swh/lister/puppet/tests/test_lister.py

Loading...
View Options

swh/lister/puppet/tests/test_tasks.py

Loading...
About · Developer information · Legal