Differential D8522

Add nameExcludePrefix filter to snapshot branch
ClosedPublic
Actions

Authored by jayeshv on Sep 22 2022, 2:53 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDGQL7e5c8240616f: Add nameExcludePrefix filter to snapshot branch

Diff Detail

Repository

rDGQL GraphQL API

Branch

branch-filter-D8522

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31754
Build 49682: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 49681: arc lint + arc unit

Event Timeline

jayeshv created this revision.Sep 22 2022, 2:53 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 22 2022, 2:53 PM

Build is green

Patch application report for D8522 (id=30689)

Rebasing onto 32d5564f97...

Current branch diff-target is up to date.

Changes applied before test

commit 5d7f9a9b9e8f72b0f1ce1b032c550052735d6849
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Sep 22 14:52:13 2022 +0200

    Add nameExcludePrefix filter to snapshot branch

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/199/ for more details.

Harbormaster completed remote builds in B31667: Diff 30689.Sep 22 2022, 2:56 PM

jayeshv requested review of this revision.Sep 22 2022, 2:56 PM

rebase

Build is green

Patch application report for D8522 (id=30777)

Rebasing onto 8d764671e9...

Current branch diff-target is up to date.

Changes applied before test

commit df734a578b5a7c04f11c2f59f65a3e6d691c3570
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Sep 22 14:52:13 2022 +0200

    Add nameExcludePrefix filter to snapshot branch

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/206/ for more details.

Harbormaster completed remote builds in B31754: Diff 30777.Sep 26 2022, 2:52 PM

I think it would make sense to make it a list, to exclude multiple prefixes

vlorentz requested changes to this revision.Sep 26 2022, 10:55 PM

This revision now requires changes to proceed.Sep 26 2022, 10:55 PM

In D8522#221749, @vlorentz wrote:

I think it would make sense to make it a list, to exclude multiple prefixes

I agree is a nice to have (same for nameInclude argument).

This depends on the swh-storage for this functionality.
https://forge.softwareheritage.org/source/swh-storage/browse/master/swh/storage/interface.py$831
Filtering in the GraphQL layer is an option, but having that in the storage sounds more logical.

It is a bit different from the nameInclude in directory entries, where the filter is not at all supported in the storage.

doc string update

Build is green

Patch application report for D8522 (id=30881)

Rebasing onto ffb88715d7...

Current branch diff-target is up to date.

Changes applied before test

commit 7e5c8240616fc52e5c11a09393853cda14e1889a
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Thu Sep 22 14:52:13 2022 +0200

    Add nameExcludePrefix filter to snapshot branch

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/208/ for more details.

Harbormaster completed remote builds in B31852: Diff 30881.Sep 28 2022, 11:36 AM

vlorentz accepted this revision.Sep 28 2022, 12:28 PM

This revision is now accepted and ready to land.Sep 28 2022, 12:28 PM

Closed by commit rDGQL7e5c8240616f: Add nameExcludePrefix filter to snapshot branch (authored by jayeshv). · Explain WhySep 28 2022, 12:32 PM

This revision was automatically updated to reflect the committed changes.

jayeshv added a commit: rDGQL7e5c8240616f: Add nameExcludePrefix filter to snapshot branch.