Differential D8444

tests/conftest: Remove sentry fixtures
ClosedPublic
Actions

Authored by anlambert on Sep 12 2022, 11:56 AM.

Details

Reviewers

olasd

Group Reviewers

Reviewers

Commits

rDCIDXe25a2f4e4a34: tests/conftest: Remove sentry fixtures

Summary

They have been moved in a swh-core pytest plugin to share them with
other swh packages that might need it.

Related to D8434

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

remove-sentry-fixtures

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31463
Build 49215: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 49214: arc lint + arc unit

Event Timeline

anlambert created this revision.Sep 12 2022, 11:56 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 12 2022, 11:56 AM

Build was aborted

Patch application report for D8444 (id=30440)

Rebasing onto 6d7efad974...

Current branch diff-target is up to date.

Changes applied before test

commit 4e38489882b26803f331d67962887f055abca427
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 12 11:54:59 2022 +0200

    tests/conftest: Remove sentry fixtures
    
    They have been moved in a swh-core pytest plugin to share them with
    other swh packages that might need it.

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/487/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/487/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 12 2022, 12:08 PM

Harbormaster failed remote builds in B31456: Diff 30440!

Build is green

Patch application report for D8444 (id=30440)

Rebasing onto 6d7efad974...

Current branch diff-target is up to date.

Changes applied before test

commit 4e38489882b26803f331d67962887f055abca427
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 12 11:54:59 2022 +0200

    tests/conftest: Remove sentry fixtures
    
    They have been moved in a swh-core pytest plugin to share them with
    other swh packages that might need it.

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/488/ for more details.

Harbormaster completed remote builds in B31456: Diff 30440.Sep 12 2022, 12:18 PM

anlambert requested review of this revision.Sep 12 2022, 12:18 PM

Thanks! I guess this needs a version bump on swh.core in requirements-swh.txt

This revision is now accepted and ready to land.Sep 12 2022, 2:39 PM

Bump swh.core requirement

Build is green

Patch application report for D8444 (id=30453)

Rebasing onto 6d7efad974...

Current branch diff-target is up to date.

Changes applied before test

commit e25a2f4e4a34bf34c4de54586a61db6f154b39e5
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 12 11:54:59 2022 +0200

    tests/conftest: Remove sentry fixtures
    
    They have been moved in a swh-core pytest plugin to share them with
    other swh packages that might need it.

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/489/ for more details.

Harbormaster completed remote builds in B31463: Diff 30453.Sep 12 2022, 2:52 PM

Closed by commit rDCIDXe25a2f4e4a34: tests/conftest: Remove sentry fixtures (authored by anlambert). · Explain WhySep 12 2022, 2:54 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDCIDXe25a2f4e4a34: tests/conftest: Remove sentry fixtures.