Add Podspec Mappings
Changes PlannedPublicDraft
Actions

Authored by VickyMerzOwn on Aug 22 2022, 10:41 PM.

Details

Reviewers

vlorentz
KShivendu

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

podspec-mapping

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31449
Build 49193: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 49192: arc lint + arc unit

Unit TestsFailed
View All

	Time	Test
	4 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.tests.metadata_dictionary.test_podspec::test_compute_metadata_podspec def test_compute_metadata_podspec(): raw_content = b"""Pod::Spec.new do \|spec\| spec.name = 'Reachability'
	5,671 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.tests.test_cli::test_cli_mapping_list cli_runner = <click.testing.CliRunner object at 0x7f55b02526d8> swh_config = '/tmp/pytest-of-jenkins/pytest-0/test_cli_mapping_list0/indexer.yml'
	4 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.codemeta::swh.indexer.codemeta.make_absolute_uri
	2 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.metadata_dictionary.github::swh.indexer.metadata_dictionary.github.GitHubMapping.normalize_license
	9 ms	Jenkins > .tox.py3.lib.python3.7.site-packages.swh.indexer.metadata_dictionary.github::swh.indexer.metadata_dictionary.github.GitHubMapping.translate_forks_count
		View Full Test Results (2 Failed · 355 Passed · 11 Skipped)

Event Timeline

VickyMerzOwn created this revision.Aug 22 2022, 10:41 PM

Build has FAILED

Patch application report for D8283 (id=29911)

Rebasing onto 466108c166...

Current branch diff-target is up to date.

Changes applied before test

commit 0333ce1ccfe939f8b3afd11a7d79f54072b82f81
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Aug 23 02:06:29 2022 +0530

    metadata_dictionary: Add mappings for "*.podspec" files

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/451/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/451/console

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 22 2022, 10:43 PM

Harbormaster failed remote builds in B30963: Diff 29911!

Add 'podspec' to list of expected_output in test_cli.test_cli_mapping_list method

Build has FAILED

Patch application report for D8283 (id=29940)

Rebasing onto e8cafad61c...

Current branch diff-target is up to date.

Changes applied before test

commit 5b86e1351f2c87c61f595070973d7115c16bdda4
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Aug 23 02:06:29 2022 +0530

    metadata_dictionary: Add mappings for "*.podspec" files

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/462/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/462/console

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 23 2022, 12:58 PM

Harbormaster failed remote builds in B30992: Diff 29940!

Parser for Ruby Enum type

Build has FAILED

Patch application report for D8283 (id=30433)

Rebasing onto b6385cec11...

First, rewinding head to replay your work on top of it...
Applying: metadata_dictionary: Add mappings for "*.podspec" files

Changes applied before test

commit f1f9bf3fd78f3616dd83ae4ded554149bf4f80b9
Author: Satvik Vemuganti <vemugantisesha@iitbhilai.ac.in>
Date:   Tue Aug 23 02:06:29 2022 +0530

    metadata_dictionary: Add mappings for "*.podspec" files

Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/486/
See console output for more information: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/486/console

Harbormaster returned this revision to the author for changes because remote builds failed.Sep 11 2022, 9:00 AM

Harbormaster failed remote builds in B31449: Diff 30433!

KShivendu added inline comments.Sep 12 2022, 9:44 AM

swh/indexer/metadata_dictionary/podspec.py
100–103	Maybe try this.

vlorentz added inline comments.Sep 12 2022, 9:48 AM

swh/indexer/metadata_dictionary/podspec.py
45–60	please reuse the code from `ruby.py`. (Actually, you could move `PodspecMapping` to that file, to keep the code tidier)
71–90	ditto. (also, the name should remain `eval_ruby_expression`, because it evaluates Ruby code)
96	don't you mean `parse_hash`?
101–103	you can simplify this