Convert SWHID to str before passing to sentry_sdk.set_tag
ClosedPublic
Actions

Authored by vlorentz on Sep 8 2022, 5:18 PM.

Details

Reviewers

ardumont
jayeshv

Group Reviewers

Reviewers

Commits

rDCIDXf4e08f950baa: Convert SWHID to str before passing to sentry_sdk.set_tag

Summary

Sentry uses repr() by default, which does not look good in a UI

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31408
Build 49131: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 49130: arc lint + arc unit

Event Timeline

vlorentz created this revision.Sep 8 2022, 5:18 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 8 2022, 5:18 PM

Build is green

Patch application report for D8427 (id=30387)

Rebasing onto b6385cec11...

Current branch diff-target is up to date.

Changes applied before test

commit f4e08f950baa4d7f9a524e0a4815becb01c6649c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 8 17:18:29 2022 +0200

    Convert SWHID to str before passing to sentry_sdk.set_tag
    
    Sentry uses repr() by default, which does not look good in a UI

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/484/ for more details.

Harbormaster completed remote builds in B31408: Diff 30387.Sep 8 2022, 5:27 PM

vlorentz requested review of this revision.Sep 8 2022, 5:27 PM

ardumont accepted this revision.Sep 8 2022, 5:27 PM

This revision is now accepted and ready to land.Sep 8 2022, 5:27 PM

jayeshv accepted this revision.Sep 8 2022, 5:27 PM

Closed by commit rDCIDXf4e08f950baa: Convert SWHID to str before passing to sentry_sdk.set_tag (authored by vlorentz). · Explain WhySep 12 2022, 10:54 AM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCIDXf4e08f950baa: Convert SWHID to str before passing to sentry_sdk.set_tag.