Page MenuHomeSoftware Heritage

github: Add support for 'topics'
ClosedPublic

Authored by vlorentz on Sep 8 2022, 11:13 AM.

Diff Detail

Repository
rDCIDX Metadata indexer
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 31387
Build 49100: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 49099: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D8416 (id=30362)

Could not rebase; Attempt merge onto 44879ab563...

Updating 44879ab..dd02741
Fast-forward
 swh/indexer/metadata.py                            | 34 +++++++++++++++-------
 swh/indexer/metadata_dictionary/github.py          |  6 +++-
 .../tests/metadata_dictionary/test_github.py       | 20 +++++++++++--
 swh/indexer/tests/test_metadata.py                 | 29 ++++++++++++++++++
 4 files changed, 75 insertions(+), 14 deletions(-)
Changes applied before test
commit dd0274193f5228ded709fb150c1685ddaafeed73
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Sep 8 11:12:56 2022 +0200

    github: Add support for 'topics'

commit befdbd7efd46dd052b8728215deeeb3f775c34d0
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 5 15:48:40 2022 +0200

    Fix crash when RawExtrinsicMetadata target new origins
    
    RawExtrinsicMetadata contain a swh:1:ori: identifier of the origin,
    which the indexer needs to resolve, by querying its storage replica.
    
    Because RawExtrinsicMetadata are created by loaders, they are often
    created shortly after the origin is created by the corresponding lister,
    so the origin may not be known to the storage replica used by the
    indexer, causing this function to crash.
    
    Waiting 10s seems to be good enough when run on my computer with
    production data and moma's replica; so I set it to 60s just to be safe.

commit 68940cfccfed258620cc116bedd6598fd9b28df4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 5 14:21:50 2022 +0200

    Fix crash when RawExtrinsicMetadata objects have the same target
    
    ... and they are processed in the same batch.
    
    The last one received takes precedence, as it is likely to be more
    up-to-date

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/482/ for more details.

This revision is now accepted and ready to land.Sep 8 2022, 4:45 PM
This revision was automatically updated to reflect the committed changes.