Differential D8395

settings/tests: Ensure swh_extra_django_apps correct value for tests
ClosedPublic
Actions

Authored by anlambert on Sep 5 2022, 4:44 PM.

Details

Reviewers

jayeshv

Group Reviewers

Reviewers

Maniphest Tasks

T4398: Create one django application for each webapp feature

Commits

rDWAPPS4df8c0e38c43: settings/tests: Ensure swh_extra_django_apps correct value for tests

Summary

Django settings can be overriden by values contained in local configuration
file so ensure correct value of swh_extra_django_apps in tests settings
to avoid bad surprises when running tests.

Also sort django application names in lexicographical order.

Related to T4398

Diff Detail

Repository

rDWAPPS Web applications

Branch

ensure-correct-tests-settings

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31324
Build 49002: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 49001: arc lint + arc unit

Event Timeline

anlambert created this revision.Sep 5 2022, 4:44 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 5 2022, 4:44 PM

Build is green

Patch application report for D8395 (id=30292)

Rebasing onto e96bc074f8...

Current branch diff-target is up to date.

Changes applied before test

commit 4df8c0e38c439ce915839fc585cff7f6d0d09f0c
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Sep 5 16:39:15 2022 +0200

    settings/tests: Ensure swh_extra_django_apps correct value for tests
    
    Django settings can be overriden by values contained in local configuration
    file so ensure correct value of swh_extra_django_apps in tests settings
    to avoid bad surprises when running tests.
    
    Also sort django application names in lexicographical order.
    
    Related to T4398

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2034/ for more details.

Harbormaster completed remote builds in B31324: Diff 30292.Sep 5 2022, 4:54 PM

anlambert requested review of this revision.Sep 5 2022, 4:54 PM

jayeshv accepted this revision.Sep 5 2022, 4:57 PM

This revision is now accepted and ready to land.Sep 5 2022, 4:57 PM

Closed by commit rDWAPPS4df8c0e38c43: settings/tests: Ensure swh_extra_django_apps correct value for tests (authored by anlambert). · Explain WhySep 5 2022, 4:57 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS4df8c0e38c43: settings/tests: Ensure swh_extra_django_apps correct value for tests.