Differential D8388

Fix crash when RawExtrinsicMetadata objects have the same target
ClosedPublic
Actions

Authored by vlorentz on Sep 5 2022, 2:23 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDCIDX68940cfccfed: Fix crash when RawExtrinsicMetadata objects have the same target

Summary

... and they are processed in the same batch.

The last one received takes precedence, as it is likely to be more
up-to-date

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31313
Build 48984: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 48983: arc lint + arc unit

Event Timeline

vlorentz created this revision.Sep 5 2022, 2:23 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 5 2022, 2:23 PM

Build is green

Patch application report for D8388 (id=30278)

Rebasing onto 44879ab563...

Current branch diff-target is up to date.

Changes applied before test

commit 68940cfccfed258620cc116bedd6598fd9b28df4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Mon Sep 5 14:21:50 2022 +0200

    Fix crash when RawExtrinsicMetadata objects have the same target
    
    ... and they are processed in the same batch.
    
    The last one received takes precedence, as it is likely to be more
    up-to-date

See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/480/ for more details.

Harbormaster completed remote builds in B31313: Diff 30278.Sep 5 2022, 2:32 PM

vlorentz requested review of this revision.Sep 5 2022, 2:32 PM