Differential D8377

Move base templates and views into a webapp django application
ClosedPublic
Actions

Authored by anlambert on Sep 1 2022, 3:06 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDWAPPS3c4ffa9198b2: Move base templates and views into a webapp django application

Summary

Also cleanup root urls.py file, all URLs are now registered from
loaded django applications.

Diff Detail

Repository

rDWAPPS Web applications

Branch

django-apps-refactoring-webapp

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31273
Build 48919: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 48918: arc lint + arc unit

Event Timeline

anlambert created this revision.Sep 1 2022, 3:06 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptSep 1 2022, 3:06 PM

Build is green

Patch application report for D8377 (id=30233)

Rebasing onto 1c36c4f969...

Current branch diff-target is up to date.

Changes applied before test

commit c0398d01ac8206bcdeec9e2e641e1470ba9916a5
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Sep 1 15:04:48 2022 +0200

    Move base templates and views into a webapp django application
    
    Also cleanup root urls.py file, all URLs are now registered from
    loaded django applications.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2029/ for more details.

Harbormaster completed remote builds in B31272: Diff 30233.Sep 1 2022, 3:14 PM

anlambert requested review of this revision.Sep 1 2022, 3:14 PM

vlorentz accepted this revision.Sep 1 2022, 4:39 PM

This revision is now accepted and ready to land.Sep 1 2022, 4:39 PM

Add related task in commit log

This revision was landed with ongoing or failed builds.Sep 1 2022, 5:10 PM

Closed by commit rDWAPPS3c4ffa9198b2: Move base templates and views into a webapp django application (authored by anlambert). · Explain Why

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS3c4ffa9198b2: Move base templates and views into a webapp django application.

Build is green

Patch application report for D8377 (id=30234)

Rebasing onto 1c36c4f969...

Current branch diff-target is up to date.

Changes applied before test

commit 3c4ffa9198b21b5f73e2d5ef41d2ae5b1b926f2f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu Sep 1 15:04:48 2022 +0200

    Move base templates and views into a webapp django application
    
    Also cleanup root urls.py file, all URLs are now registered from
    loaded django applications.
    
    Related to T4398

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2030/ for more details.

Harbormaster completed remote builds in B31273: Diff 30234.Sep 1 2022, 5:21 PM