Differential D8359

Remove no longer needed misc folder
ClosedPublic
Actions

Authored by anlambert on Aug 31 2022, 2:54 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDWAPPS13751718e949: Remove no longer needed misc folder

Summary

Also move remaining view and URLs defintion in adequate urls.py files.

Depends on D8357

Diff Detail

Repository

rDWAPPS Web applications

Branch

django-apps-refactoring-misc

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 31224
Build 48845: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 48844: arc lint + arc unit

Event Timeline

anlambert created this revision.Aug 31 2022, 2:54 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 31 2022, 2:54 PM

Build has FAILED

Patch application report for D8359 (id=30173)

Could not rebase; Attempt merge onto 5380e936f8...

Updating 5380e936..a42f02d0
Fast-forward
 .../templates/archive-coverage.html                |  4 +-
 swh/web/browse/templates/browse-iframe.html        |  8 +-
 swh/web/config.py                                  |  1 +
 swh/web/{misc => jslicenses}/__init__.py           |  0
 .../misc => jslicenses/templates}/jslicenses.html  |  2 +-
 swh/web/jslicenses/urls.py                         | 26 ++++++
 swh/web/misc/urls.py                               | 98 ----------------------
 swh/web/templates/layout.html                      |  4 +-
 swh/web/tests/jslicenses/__init__.py               |  0
 swh/web/tests/jslicenses/test_app.py               | 35 ++++++++
 swh/web/tests/jslicenses/test_jslicenses.py        | 14 ++++
 swh/web/tests/urls.py                              | 47 +++++++++++
 swh/web/urls.py                                    | 23 ++++-
 13 files changed, 156 insertions(+), 106 deletions(-)
 rename swh/web/{misc => jslicenses}/__init__.py (100%)
 rename swh/web/{templates/misc => jslicenses/templates}/jslicenses.html (98%)
 create mode 100644 swh/web/jslicenses/urls.py
 delete mode 100644 swh/web/misc/urls.py
 create mode 100644 swh/web/tests/jslicenses/__init__.py
 create mode 100644 swh/web/tests/jslicenses/test_app.py
 create mode 100644 swh/web/tests/jslicenses/test_jslicenses.py
 create mode 100644 swh/web/tests/urls.py

Changes applied before test

commit a42f02d089a9fda351b18039859de09ab6481231
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Aug 31 14:51:29 2022 +0200

    Remove no longer needed misc folder
    
    Also move remaining view and URLs defintion in adequate urls.py files.

commit 7617d615b2ca118153ed44eb65b1acf5c7681b46
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Aug 31 14:15:54 2022 +0200

    misc/jslicenses: Move feature into its own django application
    
    Related to T4398

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2022/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2022/console

Harbormaster returned this revision to the author for changes because remote builds failed.Aug 31 2022, 3:07 PM

Harbormaster failed remote builds in B31218: Diff 30173!

Fix cypress tests and add Python test for stat counters view.

Build is green

Patch application report for D8359 (id=30180)

Could not rebase; Attempt merge onto 5380e936f8...

Updating 5380e936..13751718
Fast-forward
 .../templates/archive-coverage.html                |  4 +-
 swh/web/browse/templates/browse-iframe.html        |  8 +-
 swh/web/config.py                                  |  1 +
 swh/web/{misc => jslicenses}/__init__.py           |  0
 .../misc => jslicenses/templates}/jslicenses.html  |  2 +-
 swh/web/jslicenses/urls.py                         | 26 ++++++
 swh/web/misc/urls.py                               | 98 ----------------------
 swh/web/templates/layout.html                      |  4 +-
 swh/web/tests/jslicenses/__init__.py               |  0
 swh/web/tests/jslicenses/test_app.py               | 35 ++++++++
 swh/web/tests/jslicenses/test_jslicenses.py        | 14 ++++
 swh/web/tests/test_urls.py                         |  8 ++
 swh/web/tests/urls.py                              | 47 +++++++++++
 swh/web/urls.py                                    | 24 +++++-
 14 files changed, 165 insertions(+), 106 deletions(-)
 rename swh/web/{misc => jslicenses}/__init__.py (100%)
 rename swh/web/{templates/misc => jslicenses/templates}/jslicenses.html (98%)
 create mode 100644 swh/web/jslicenses/urls.py
 delete mode 100644 swh/web/misc/urls.py
 create mode 100644 swh/web/tests/jslicenses/__init__.py
 create mode 100644 swh/web/tests/jslicenses/test_app.py
 create mode 100644 swh/web/tests/jslicenses/test_jslicenses.py
 create mode 100644 swh/web/tests/urls.py

Changes applied before test

commit 13751718e949d3a0c728f145c88ffe03fbd202b3
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Aug 31 14:51:29 2022 +0200

    Remove no longer needed misc folder
    
    Also move remaining view and URLs defintion in adequate urls.py files.

commit 7617d615b2ca118153ed44eb65b1acf5c7681b46
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed Aug 31 14:15:54 2022 +0200

    misc/jslicenses: Move feature into its own django application
    
    Related to T4398

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/2023/ for more details.

Harbormaster completed remote builds in B31224: Diff 30180.Aug 31 2022, 3:43 PM

anlambert requested review of this revision.Aug 31 2022, 3:43 PM

vlorentz accepted this revision.Aug 31 2022, 4:14 PM

This revision is now accepted and ready to land.Aug 31 2022, 4:14 PM

Closed by commit rDWAPPS13751718e949: Remove no longer needed misc folder (authored by anlambert). · Explain WhyAug 31 2022, 4:20 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS13751718e949: Remove no longer needed misc folder.