Page MenuHomeSoftware Heritage
Differential D8352

staging/graphql: Push issues to sentry
ClosedPublic
Actions

Authored by ardumont on Aug 31 2022, 11:14 AM.

Details

Reviewers
vsellier
Group Reviewers
System administrators
Maniphest Tasks
T4135: staging: Deploy graphql service
Commits
R260:5aed44119bb7: staging/graphql: Push issues to sentry
Summary

Related to T4135

Diff Detail

Repository
R260 Helm charts for swh packages
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 31208
Build 48815: arc lint + arc unit

Event Timeline

ardumont created this revision.Aug 31 2022, 11:14 AM
Herald added a reviewer: System administrators. · View Herald TranscriptAug 31 2022, 11:14 AM
Harbormaster completed remote builds in B31201: Diff 30157.Aug 31 2022, 11:14 AM
ardumont requested review of this revision.Aug 31 2022, 11:14 AM
ardumont updated this revision to Diff 30164.Aug 31 2022, 11:57 AM

Rebase

Harbormaster completed remote builds in B31208: Diff 30164.Aug 31 2022, 11:57 AM
vsellier requested changes to this revision.Aug 31 2022, 3:48 PM
vsellier added a subscriber: vsellier.
vsellier added inline comments.
swh/templates/graphql/deployment.yaml
48

perhaps the whole sentry configuration part should be put inside a if because in an environment without sentry,
the secret will still be needed to start the container.

This revision now requires changes to proceed.Aug 31 2022, 3:48 PM
ardumont added inline comments.Aug 31 2022, 3:52 PM
swh/templates/graphql/deployment.yaml
48

Do we really want to allow sentry not being configured?

ardumont updated this revision to Diff 30182.Aug 31 2022, 3:57 PM

Add a check prior to activate the sentry configuration

Harbormaster completed remote builds in B31226: Diff 30182.Aug 31 2022, 3:57 PM
vsellier added inline comments.Aug 31 2022, 4:04 PM
swh/templates/graphql/deployment.yaml
48

yes, not everyone or every environment have a sentry (dev / test / mirrors / ...)

ardumont marked 2 inline comments as done.Aug 31 2022, 4:47 PM
vsellier accepted this revision.Aug 31 2022, 4:54 PM
This revision is now accepted and ready to land.Aug 31 2022, 4:54 PM
Closed by commit R260:5aed44119bb7: staging/graphql: Push issues to sentry (authored by ardumont). · Explain WhyAug 31 2022, 4:56 PM
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: R260:5aed44119bb7: staging/graphql: Push issues to sentry.

Revision Contents
Changeset List

PathSize
swh/
templates/
graphql/
11 lines

Diff 30164

View Options

swh/templates/graphql/deployment.yaml

Loading...
About · Developer information · Legal