Page MenuHomeSoftware Heritage

staging/graphql: Push issues to sentry
ClosedPublic

Authored by ardumont on Aug 31 2022, 11:14 AM.

Diff Detail

Repository
R260 Helm charts for swh packages
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 31201
Build 48804: arc lint + arc unit

Event Timeline

vsellier added a subscriber: vsellier.
vsellier added inline comments.
swh/templates/graphql/deployment.yaml
47

perhaps the whole sentry configuration part should be put inside a if because in an environment without sentry,
the secret will still be needed to start the container.

This revision now requires changes to proceed.Aug 31 2022, 3:48 PM
swh/templates/graphql/deployment.yaml
47

Do we really want to allow sentry not being configured?

Add a check prior to activate the sentry configuration

swh/templates/graphql/deployment.yaml
47

yes, not everyone or every environment have a sentry (dev / test / mirrors / ...)

This revision is now accepted and ready to land.Aug 31 2022, 4:54 PM
This revision was automatically updated to reflect the committed changes.