Differential D8288

Add missing functional tests for the Directory and DirectoryEntry types
ClosedPublic
Actions

Authored by jayeshv on Aug 23 2022, 10:52 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T4292: Add missing functional tests for GraphQL APIs

Commits

rDGQL6fb1913ff935: Add missing functional tests for the Directory and DirectoryEntry types

Summary

Related to T4292

Diff Detail

Repository

rDGQL GraphQL API

Branch

directory-tests

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 30980
Build 48458: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 48457: arc lint + arc unit

Event Timeline

jayeshv created this revision.Aug 23 2022, 10:52 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 23 2022, 10:52 AM

typo

Build is green

Patch application report for D8288 (id=29925)

Rebasing onto 3e11273648...

Current branch diff-target is up to date.

Changes applied before test

commit 3be39a345626057800e3082d00bc486aeeb03fbe
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Aug 23 10:31:20 2022 +0200

    Add missing functional tests for the Directory and DirectoryEntry types
    
    Related to T4292

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/117/ for more details.

Harbormaster completed remote builds in B30977: Diff 29925.Aug 23 2022, 10:55 AM

Build is green

Patch application report for D8288 (id=29927)

Rebasing onto 3e11273648...

Current branch diff-target is up to date.

Changes applied before test

commit 3795595d7c146a611f72a299597d9b23a708294d
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Aug 23 10:31:20 2022 +0200

    Add missing functional tests for the Directory and DirectoryEntry types
    
    Related to T4292

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/118/ for more details.

Harbormaster completed remote builds in B30979: Diff 29927.Aug 23 2022, 10:56 AM

jayeshv requested review of this revision.Aug 23 2022, 10:56 AM

lgtm

one typo and one question inline.

swh/graphql/tests/functional/test_directory.py
57
72	why 2 calls?

This revision is now accepted and ready to land.Aug 23 2022, 11:09 AM

fix issues found in review

jayeshv marked 2 inline comments as done.Aug 23 2022, 11:14 AM

jayeshv added inline comments.

swh/graphql/tests/functional/test_directory.py
72	Copy paste error, thanks :)

Build is green

Patch application report for D8288 (id=29928)

Rebasing onto 3e11273648...

Current branch diff-target is up to date.

Changes applied before test

commit 6fb1913ff935d9762ad055a54acf57594c80f7fc
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Aug 23 10:31:20 2022 +0200

    Add missing functional tests for the Directory and DirectoryEntry types
    
    Related to T4292

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/119/ for more details.

Harbormaster completed remote builds in B30980: Diff 29928.Aug 23 2022, 11:15 AM

Closed by commit rDGQL6fb1913ff935: Add missing functional tests for the Directory and DirectoryEntry types (authored by jayeshv). · Explain WhyAug 23 2022, 11:16 AM

This revision was automatically updated to reflect the committed changes.

jayeshv marked an inline comment as done.

jayeshv added a commit: rDGQL6fb1913ff935: Add missing functional tests for the Directory and DirectoryEntry types.