Page MenuHomeSoftware Heritage

Add missing functional tests for the Directory and DirectoryEntry types
ClosedPublic

Authored by jayeshv on Aug 23 2022, 10:52 AM.

Diff Detail

Repository
rDGQL GraphQL API
Branch
directory-tests
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 30979
Build 48456: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 48455: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D8288 (id=29925)

Rebasing onto 3e11273648...

Current branch diff-target is up to date.
Changes applied before test
commit 3be39a345626057800e3082d00bc486aeeb03fbe
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Aug 23 10:31:20 2022 +0200

    Add missing functional tests for the Directory and DirectoryEntry types
    
    Related to T4292

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/117/ for more details.

Build is green

Patch application report for D8288 (id=29927)

Rebasing onto 3e11273648...

Current branch diff-target is up to date.
Changes applied before test
commit 3795595d7c146a611f72a299597d9b23a708294d
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Aug 23 10:31:20 2022 +0200

    Add missing functional tests for the Directory and DirectoryEntry types
    
    Related to T4292

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/118/ for more details.

ardumont added a subscriber: ardumont.

lgtm

one typo and one question inline.

swh/graphql/tests/functional/test_directory.py
57
72

why 2 calls?

This revision is now accepted and ready to land.Aug 23 2022, 11:09 AM
jayeshv added inline comments.
swh/graphql/tests/functional/test_directory.py
72

Copy paste error, thanks :)

Build is green

Patch application report for D8288 (id=29928)

Rebasing onto 3e11273648...

Current branch diff-target is up to date.
Changes applied before test
commit 6fb1913ff935d9762ad055a54acf57594c80f7fc
Author: Jayesh Velayudhan <jayesh@softwareheritage.org>
Date:   Tue Aug 23 10:31:20 2022 +0200

    Add missing functional tests for the Directory and DirectoryEntry types
    
    Related to T4292

See https://jenkins.softwareheritage.org/job/DGQL/job/tests-on-diff/119/ for more details.