Differential D8285

Fix mypy error
ClosedPublic
Actions

Authored by vlorentz on Aug 23 2022, 10:26 AM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDCORE843a010cf646: Fix mypy error

Summary

Without the return, 'psycopg2.connect(db_or_conninfo)' is actually reachable
when calling next() twice on the generator

Diff Detail

Repository

rDCORE Foundations and core functionalities

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 30969
Build 48438: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 48437: arc lint + arc unit

Event Timeline

vlorentz created this revision.Aug 23 2022, 10:26 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 23 2022, 10:26 AM

Build is green

Patch application report for D8285 (id=29917)

Rebasing onto c232fb093e...

Current branch diff-target is up to date.

Changes applied before test

commit 843a010cf646272f9323bb064aa9dc29c9221599
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Aug 23 10:26:00 2022 +0200

    Fix mypy error
    
    Without the return, 'psycopg2.connect(db_or_conninfo)' is actually reachable
    when calling next() twice on the generator

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/471/ for more details.

Harbormaster completed remote builds in B30969: Diff 29917.Aug 23 2022, 10:27 AM

vlorentz requested review of this revision.Aug 23 2022, 10:27 AM