Differential D8230

Add-forge-now: Change word-wrapping of email template to 72 columns
ClosedPublic
Actions

Authored by vlorentz on Aug 10 2022, 11:12 AM.

Details

Reviewers

anlambert

Group Reviewers

Reviewers

Commits

rDWAPPS46f08274080f: Add-forge-now: Change word-wrapping of email template to 72 columns

Summary

It looks weird when email clients soft-wrap on smaller number
of columns; eg. Thunderbird defaults to 72 when editing in
plain text.

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Aug 10 2022, 11:12 AM

Herald added a reviewer: Reviewers. · View Herald TranscriptAug 10 2022, 11:12 AM

Build is green

Patch application report for D8230 (id=29686)

Rebasing onto 708fb87322...

Current branch diff-target is up to date.

Changes applied before test

commit 7a964591abbafa791e563c35450691d9886b37a4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 10 11:12:15 2022 +0200

    Add-forge-now: Remove hard word-wrappings from the email template
    
    It looks weird when email clients soft-wrap on smaller number
    of columns; eg. Thunderbird defaults to 72 when editing in
    plain text.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1957/ for more details.

Harbormaster completed remote builds in B30739: Diff 29686.Aug 10 2022, 11:30 AM

vlorentz requested review of this revision.Aug 10 2022, 11:30 AM

I would prefer to wrap the text to 72 columns then.

re-wrap at 72 cols

vlorentz retitled this revision from Add-forge-now: Remove hard word-wrappings from the email template to Add-forge-now: Change word-wrapping of email template to 72 columns.Aug 10 2022, 11:51 AM

vlorentz edited the summary of this revision. (Show Details)

anlambert accepted this revision.Aug 10 2022, 11:54 AM

This revision is now accepted and ready to land.Aug 10 2022, 11:54 AM

Build is green

Patch application report for D8230 (id=29687)

Rebasing onto 708fb87322...

Current branch diff-target is up to date.

Changes applied before test

commit 46f08274080fba4c15019fd05e0ceb3072f157c1
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Wed Aug 10 11:12:15 2022 +0200

    Add-forge-now: Change word-wrapping of email template to 72 columns
    
    It looks weird when email clients soft-wrap on smaller number
    of columns; eg. Thunderbird defaults to 72 when editing in
    plain text.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1958/ for more details.

Harbormaster completed remote builds in B30740: Diff 29687.Aug 10 2022, 12:08 PM

Closed by commit rDWAPPS46f08274080f: Add-forge-now: Change word-wrapping of email template to 72 columns (authored by vlorentz). · Explain WhyAug 10 2022, 2:14 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDWAPPS46f08274080f: Add-forge-now: Change word-wrapping of email template to 72 columns.