Page MenuHomeSoftware Heritage
Differential D8133

Fix mypy error
ClosedPublic
Actions

Authored by vlorentz on Jul 19 2022, 1:09 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDDEPd89a92ae8d8b: Fix mypy error

Diff Detail

Repository
rDDEP Push deposit
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 30448
Build 47598: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 47597: arc lint + arc unit

Unit TestsFailed
View All

TimeTest
2,513 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_collection_post_atom::test_deposit_metadata_swhid[swh:1:rev:71b5c8cc985d190b5a7ef4878128ebfdc2358f49;origin=h://g.c/o/repo]
swhid = 'swh:1:rev:71b5c8cc985d190b5a7ef4878128ebfdc2358f49;origin=h://g.c/o/repo' authenticated_client = <rest_framework.test.APIClient object at 0x7f0bf7fd4940> deposit_collection = <DepositCollection: {'id': 45, 'name': 'test'}>
712 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_basic_auth::test_service_document_basic
731 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_checks::test_api_checks_check_metadata_ko[no-author]
721 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_checks::test_api_checks_check_metadata_ko[no-name-or-title]
616 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.deposit.tests.api.test_checks::test_api_checks_check_metadata_ko[wrong-author-namespace]
View Full Test Results (1 Failed · 334 Passed)

Event Timeline

vlorentz created this revision.Jul 19 2022, 1:09 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 19 2022, 1:09 PM
swh-public-ci added a comment.Jul 19 2022, 1:16 PM

Build has FAILED

Patch application report for D8133 (id=29374)

Rebasing onto fb2c2d825a...

Current branch diff-target is up to date.
Changes applied before test
commit d89a92ae8d8b12ef18f275bc93728de04721c279
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jul 19 13:09:17 2022 +0200

    Fix mypy error

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/847/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/847/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 19 2022, 1:16 PM
Harbormaster failed remote builds in B30448: Diff 29374!
swh-public-ci added a comment.Jul 19 2022, 1:29 PM

Build has FAILED

Patch application report for D8133 (id=29374)

Rebasing onto fb2c2d825a...

Current branch diff-target is up to date.
Changes applied before test
commit d89a92ae8d8b12ef18f275bc93728de04721c279
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jul 19 13:09:17 2022 +0200

    Fix mypy error

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/850/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/850/console

vlorentz requested review of this revision.Jul 19 2022, 1:45 PM

test failure is unrelated, it will be fixed by D8134

ardumont accepted this revision.Jul 19 2022, 5:07 PM
This revision is now accepted and ready to land.Jul 19 2022, 5:07 PM
This revision was landed with ongoing or failed builds.Jul 19 2022, 5:10 PM
Closed by commit rDDEPd89a92ae8d8b: Fix mypy error (authored by vlorentz). · Explain Why
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDDEPd89a92ae8d8b: Fix mypy error.
vlorentz mentioned this in D8140: docs/specs/protocol-reference: Clarify statement.Jul 19 2022, 5:15 PM

Revision Contents
Changeset List

PathSize
swh/
deposit/
migrations/
2 lines

Diff 29374

View Options

swh/deposit/migrations/0018_migrate_swhids.py

Loading...
About · Developer information · Legal