Page MenuHomeSoftware Heritage
Differential D8099

Remove unused mongo backend
ClosedPublic
Actions

Authored by douardda on Jul 8 2022, 11:53 AM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Commits
rDPROV9d031913d29c: Remove unused mongo backend
Summary

Depends on D8098

Diff Detail

Unit TestsFailed
View All

TimeTest
47,056 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.provenance.tests.test_journal_client::test_cli_revision_from_journal_client
swh_storage = <swh.storage.postgresql.storage.Storage object at 0x7f96d8096780> swh_storage_backend_config = {'check_config': {'check_write': True}, 'cls': 'postgresql', 'db': "user=postgres password=xxx dbname=tests host=127.0.0.1 port=24084 options=''", 'objstorage': {'cls': 'memory'}} kafka_prefix = 'irlnnixtyw', kafka_server = '127.0.0.1:40521'
14,076 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.provenance.tests.test_journal_client::test_cli_origin_from_journal_client

Event Timeline

douardda created this revision.Jul 8 2022, 11:53 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptJul 8 2022, 11:53 AM
douardda added a child revision: D8100: Add a `swh provenance directory flatten` command.Jul 8 2022, 11:53 AM
swh-public-ci added a comment.Jul 8 2022, 12:02 PM

Build is green

Patch application report for D8099 (id=29238)

Could not rebase; Attempt merge onto af616497e1...

Updating af61649..6e445ea
Fast-forward
 swh/provenance/__init__.py                      |   6 -
 swh/provenance/cli.py                           | 189 ++++++++-
 swh/provenance/journal_client.py                |  32 +-
 swh/provenance/mongo/README.md                  |  44 --
 swh/provenance/mongo/__init__.py                |   0
 swh/provenance/mongo/backend.py                 | 529 ------------------------
 swh/provenance/tests/conftest.py                |  19 +-
 swh/provenance/tests/test_provenance_storage.py |   5 -
 8 files changed, 212 insertions(+), 612 deletions(-)
 delete mode 100644 swh/provenance/mongo/README.md
 delete mode 100644 swh/provenance/mongo/__init__.py
 delete mode 100644 swh/provenance/mongo/backend.py
Changes applied before test
commit 6e445ea9d16c6f25565a809f8abb5b7ad9b85a83
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 8 11:50:33 2022 +0200

    Remove unused mongo backend

commit 357917df50aec745ec024b3d46306ed870e87c20
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 8 11:41:11 2022 +0200

    Add a `swh provenance revision from-journal` command
    
    allowing to ingest revisions from the kafka journal.
    
    Also provide a `swh provenance revision from-csv` command to replace the
    `swh provenance iter-revision` command.

commit 2492c8c97a2506b0aa2e1507af42f2c2fc37117f
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 8 11:34:35 2022 +0200

    Rename process_journal_objects as process_journal_origins
    
    since it's only dealing with origins.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/638/ for more details.

Harbormaster completed remote builds in B30323: Diff 29238.Jul 8 2022, 12:02 PM
douardda requested review of this revision.Jul 8 2022, 12:02 PM
olasd accepted this revision.Jul 8 2022, 1:55 PM
olasd added a subscriber: olasd.

Welp.

This revision is now accepted and ready to land.Jul 8 2022, 1:55 PM
douardda updated this revision to Diff 29245.Jul 8 2022, 2:38 PM

rebase

douardda updated this revision to Diff 29248.Jul 8 2022, 2:41 PM

rebase

swh-public-ci added a comment.Jul 8 2022, 2:42 PM

Build has FAILED

Patch application report for D8099 (id=29245)

Could not rebase; Attempt merge onto af616497e1...

Updating af61649..6786d04
Fast-forward
 swh/provenance/__init__.py                      |   6 -
 swh/provenance/cli.py                           | 189 ++++++++-
 swh/provenance/journal_client.py                |  32 +-
 swh/provenance/mongo/README.md                  |  44 --
 swh/provenance/mongo/__init__.py                |   0
 swh/provenance/mongo/backend.py                 | 529 ------------------------
 swh/provenance/tests/conftest.py                |  19 +-
 swh/provenance/tests/test_journal_client.py     |  53 +++
 swh/provenance/tests/test_provenance_storage.py |   5 -
 9 files changed, 265 insertions(+), 612 deletions(-)
 delete mode 100644 swh/provenance/mongo/README.md
 delete mode 100644 swh/provenance/mongo/__init__.py
 delete mode 100644 swh/provenance/mongo/backend.py
Changes applied before test
commit 6786d040f446140160242bb9d64740ebf3002190
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 8 11:50:33 2022 +0200

    Remove unused mongo backend

commit 545e14734f9df08759d4fcabb9621b05025a3048
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 8 11:41:11 2022 +0200

    Add a `swh provenance revision from-journal` command
    
    allowing to ingest revisions from the kafka journal.
    
    Also provide a `swh provenance revision from-csv` command to replace the
    `swh provenance iter-revision` command.

commit 2492c8c97a2506b0aa2e1507af42f2c2fc37117f
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 8 11:34:35 2022 +0200

    Rename process_journal_objects as process_journal_origins
    
    since it's only dealing with origins.

Link to build: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/642/
See console output for more information: https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/642/console

Harbormaster failed remote builds in B30331: Diff 29245!Jul 8 2022, 2:42 PM
swh-public-ci added a comment.Jul 8 2022, 2:52 PM

Build is green

Patch application report for D8099 (id=29248)

Could not rebase; Attempt merge onto af616497e1...

Updating af61649..e49a047
Fast-forward
 swh/provenance/__init__.py                      |   6 -
 swh/provenance/cli.py                           | 189 ++++++++-
 swh/provenance/journal_client.py                |  32 +-
 swh/provenance/mongo/README.md                  |  44 --
 swh/provenance/mongo/__init__.py                |   0
 swh/provenance/mongo/backend.py                 | 529 ------------------------
 swh/provenance/tests/conftest.py                |  19 +-
 swh/provenance/tests/test_journal_client.py     |  52 +++
 swh/provenance/tests/test_provenance_storage.py |   5 -
 9 files changed, 264 insertions(+), 612 deletions(-)
 delete mode 100644 swh/provenance/mongo/README.md
 delete mode 100644 swh/provenance/mongo/__init__.py
 delete mode 100644 swh/provenance/mongo/backend.py
Changes applied before test
commit e49a047cb0d19b4cbb735c30d13ad166eed44a3e
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 8 11:50:33 2022 +0200

    Remove unused mongo backend

commit 719a74d881415a5ff3601d7a4b57c342764dd2ce
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 8 11:41:11 2022 +0200

    Add a `swh provenance revision from-journal` command
    
    allowing to ingest revisions from the kafka journal.
    
    Also provide a `swh provenance revision from-csv` command to replace the
    `swh provenance iter-revision` command.

commit 2492c8c97a2506b0aa2e1507af42f2c2fc37117f
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 8 11:34:35 2022 +0200

    Rename process_journal_objects as process_journal_origins
    
    since it's only dealing with origins.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/645/ for more details.

Harbormaster completed remote builds in B30334: Diff 29248.Jul 8 2022, 2:52 PM
douardda updated this revision to Diff 29254.Jul 8 2022, 5:13 PM

rebase and remove refs to mongo in config files (mypy, pytest, requirements)

swh-public-ci added a comment.Jul 8 2022, 5:23 PM

Build is green

Patch application report for D8099 (id=29254)

Could not rebase; Attempt merge onto af616497e1...

Updating af61649..9d03191
Fast-forward
 mypy.ini                                        |   3 -
 pytest.ini                                      |   4 -
 requirements-test.txt                           |   1 -
 requirements.txt                                |   2 -
 swh/provenance/__init__.py                      |   6 -
 swh/provenance/cli.py                           | 189 ++++++++-
 swh/provenance/journal_client.py                |  33 +-
 swh/provenance/mongo/README.md                  |  44 --
 swh/provenance/mongo/__init__.py                |   0
 swh/provenance/mongo/backend.py                 | 529 ------------------------
 swh/provenance/tests/conftest.py                |  19 +-
 swh/provenance/tests/test_journal_client.py     |  55 ++-
 swh/provenance/tests/test_provenance_storage.py |   5 -
 13 files changed, 267 insertions(+), 623 deletions(-)
 delete mode 100644 swh/provenance/mongo/README.md
 delete mode 100644 swh/provenance/mongo/__init__.py
 delete mode 100644 swh/provenance/mongo/backend.py
Changes applied before test
commit 9d031913d29c59c5dc87991742bd4080c26ff73c
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 8 11:50:33 2022 +0200

    Remove unused mongo backend

commit e30e9f68262f079468dc7491c2c958530131af16
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 8 11:41:11 2022 +0200

    Add a `swh provenance revision from-journal` command
    
    allowing to ingest revisions from the kafka journal.
    
    Also provide a `swh provenance revision from-csv` command to replace the
    `swh provenance iter-revision` command.

commit 2492c8c97a2506b0aa2e1507af42f2c2fc37117f
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 8 11:34:35 2022 +0200

    Rename process_journal_objects as process_journal_origins
    
    since it's only dealing with origins.

See https://jenkins.softwareheritage.org/job/DPROV/job/tests-on-diff/648/ for more details.

Harbormaster completed remote builds in B30340: Diff 29254.Jul 8 2022, 5:23 PM
Closed by commit rDPROV9d031913d29c: Remove unused mongo backend (authored by douardda). · Explain WhyJul 9 2022, 10:02 AM
This revision was automatically updated to reflect the committed changes.
douardda added a commit: rDPROV9d031913d29c: Remove unused mongo backend.

Revision Contents
Changeset List

PathSize
swh/
provenance/
6 lines
5 lines
mongo/
tests/
19 lines
5 lines

Diff 29245

View Options

swh/provenance/__init__.py

Loading...
View Options

swh/provenance/cli.py

Loading...
View Options

swh/provenance/mongo/README.md

Loading...
View Options

swh/provenance/mongo/__init__.py

Loading...
View Options

swh/provenance/mongo/backend.py

Loading...
View Options

swh/provenance/tests/conftest.py

Loading...
View Options

swh/provenance/tests/test_provenance_storage.py

Loading...
About · Developer information · Legal