detect_metadata_files and extrinsic_metadata_formats (respectively) are somewhat
mutually exclusive, so it does not make much sense to have them in the same
class and MAPPINGS dict
Partially addresses comments in D8053
Paths
| Differential D8072 Authored by vlorentz on Jul 4 2022, 1:38 PM.
Details
Summary detect_metadata_files and extrinsic_metadata_formats (respectively) are somewhat Partially addresses comments in D8053
Diff Detail
Event TimelineHerald added a reviewer: Reviewers. · View Herald TranscriptJul 4 2022, 1:38 PM2022-07-04 13:38:45 (UTC+2) Comment Actions Build has FAILED Patch application report for D8072 (id=29135)Could not rebase; Attempt merge onto 61b22345e7... Updating 61b2234..8340183 Fast-forward swh/indexer/metadata.py | 10 +++-- swh/indexer/metadata_detector.py | 4 +- swh/indexer/metadata_dictionary/__init__.py | 12 +++++- swh/indexer/metadata_dictionary/base.py | 59 +++++++++++++++++------------ swh/indexer/metadata_dictionary/cff.py | 10 ++--- swh/indexer/metadata_dictionary/codemeta.py | 4 +- swh/indexer/metadata_dictionary/github.py | 4 +- swh/indexer/metadata_dictionary/maven.py | 4 +- swh/indexer/metadata_dictionary/npm.py | 4 +- swh/indexer/metadata_dictionary/python.py | 4 +- swh/indexer/metadata_dictionary/ruby.py | 4 +- 11 files changed, 69 insertions(+), 50 deletions(-) Changes applied before testcommit 8340183b9574a40f540b0fa18013b9daf0fb54b6 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Mon Jul 4 13:37:58 2022 +0200 Use separate base classes for intrinsic and extrinsic mappings detect_metadata_files and extrinsic_metadata_formats (respectively) are somewhat mutually exclusive, so it does not make much sense to have them in the same class and MAPPINGS dict commit d84d1a47c3fbfe6eff2afd26253382f9f3fd13e5 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Mon Jul 4 13:03:17 2022 +0200 cff: Remove redundant @context setting It is already set by _translate_dict itself. Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/321/ Harbormaster failed remote builds in B30228: Diff 29135!Jul 4 2022, 1:44 PM2022-07-04 13:44:30 (UTC+2) Comment Actions Build has FAILED Patch application report for D8072 (id=29136)Could not rebase; Attempt merge onto 61b22345e7... Updating 61b2234..5fb5092 Fast-forward docs/metadata-workflow.rst | 6 ++- swh/indexer/metadata.py | 10 +++-- swh/indexer/metadata_detector.py | 4 +- swh/indexer/metadata_dictionary/__init__.py | 12 +++++- swh/indexer/metadata_dictionary/base.py | 59 +++++++++++++++++------------ swh/indexer/metadata_dictionary/cff.py | 10 ++--- swh/indexer/metadata_dictionary/codemeta.py | 4 +- swh/indexer/metadata_dictionary/github.py | 4 +- swh/indexer/metadata_dictionary/maven.py | 4 +- swh/indexer/metadata_dictionary/npm.py | 4 +- swh/indexer/metadata_dictionary/python.py | 4 +- swh/indexer/metadata_dictionary/ruby.py | 4 +- 12 files changed, 73 insertions(+), 52 deletions(-) Changes applied before testcommit 5fb5092657ba4c3dd51c079eaba397f52f4f5f9d Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Mon Jul 4 13:37:58 2022 +0200 Use separate base classes for intrinsic and extrinsic mappings detect_metadata_files and extrinsic_metadata_formats (respectively) are somewhat mutually exclusive, so it does not make much sense to have them in the same class and MAPPINGS dict commit d84d1a47c3fbfe6eff2afd26253382f9f3fd13e5 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Mon Jul 4 13:03:17 2022 +0200 cff: Remove redundant @context setting It is already set by _translate_dict itself. Link to build: https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/322/ Harbormaster returned this revision to the author for changes because remote builds failed.Jul 4 2022, 1:47 PM2022-07-04 13:47:44 (UTC+2) Comment Actions Build is green Patch application report for D8072 (id=29139)Could not rebase; Attempt merge onto 61b22345e7... Updating 61b2234..7a2d641 Fast-forward docs/metadata-workflow.rst | 6 ++- swh/indexer/metadata.py | 10 +++-- swh/indexer/metadata_detector.py | 4 +- swh/indexer/metadata_dictionary/__init__.py | 12 +++++- swh/indexer/metadata_dictionary/base.py | 59 +++++++++++++++++------------ swh/indexer/metadata_dictionary/cff.py | 10 ++--- swh/indexer/metadata_dictionary/codemeta.py | 4 +- swh/indexer/metadata_dictionary/github.py | 4 +- swh/indexer/metadata_dictionary/maven.py | 4 +- swh/indexer/metadata_dictionary/npm.py | 4 +- swh/indexer/metadata_dictionary/python.py | 4 +- swh/indexer/metadata_dictionary/ruby.py | 4 +- 12 files changed, 73 insertions(+), 52 deletions(-) Changes applied before testcommit 7a2d641f4fdd2f9922800e4f12c99646cf86cb6f Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Mon Jul 4 13:37:58 2022 +0200 Use separate base classes for intrinsic and extrinsic mappings detect_metadata_files and extrinsic_metadata_formats (respectively) are somewhat mutually exclusive, so it does not make much sense to have them in the same class and MAPPINGS dict commit d84d1a47c3fbfe6eff2afd26253382f9f3fd13e5 Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Mon Jul 4 13:03:17 2022 +0200 cff: Remove redundant @context setting It is already set by _translate_dict itself. See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/324/ for more details. Harbormaster completed remote builds in B30231: Diff 29139.Jul 4 2022, 2:10 PM2022-07-04 14:10:38 (UTC+2) Comment Actions Build is green Patch application report for D8072 (id=29169)Could not rebase; Attempt merge onto ff2730c3f6... Updating ff2730c..7dfc75c Fast-forward docs/metadata-workflow.rst | 6 ++- swh/indexer/metadata.py | 10 +++-- swh/indexer/metadata_detector.py | 4 +- swh/indexer/metadata_dictionary/__init__.py | 12 +++++- swh/indexer/metadata_dictionary/base.py | 59 +++++++++++++++++------------ swh/indexer/metadata_dictionary/cff.py | 10 ++--- swh/indexer/metadata_dictionary/codemeta.py | 4 +- swh/indexer/metadata_dictionary/composer.py | 4 +- swh/indexer/metadata_dictionary/github.py | 4 +- swh/indexer/metadata_dictionary/maven.py | 4 +- swh/indexer/metadata_dictionary/npm.py | 4 +- swh/indexer/metadata_dictionary/python.py | 4 +- swh/indexer/metadata_dictionary/ruby.py | 4 +- 13 files changed, 75 insertions(+), 54 deletions(-) Changes applied before testcommit 7dfc75cf1af32c0c7dc066434287ecb65091dc5c Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Mon Jul 4 13:37:58 2022 +0200 Use separate base classes for intrinsic and extrinsic mappings detect_metadata_files and extrinsic_metadata_formats (respectively) are somewhat mutually exclusive, so it does not make much sense to have them in the same class and MAPPINGS dict commit c2742b5b75f62a550ee905699cd47b5b13eac52a Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Mon Jul 4 13:03:17 2022 +0200 cff: Remove redundant @context setting It is already set by _translate_dict itself. See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/333/ for more details. Harbormaster completed remote builds in B30259: Diff 29169.Jul 5 2022, 3:33 PM2022-07-05 15:33:36 (UTC+2) Comment Actions Build is green Patch application report for D8072 (id=29171)Could not rebase; Attempt merge onto ff2730c3f6... Updating ff2730c..d41f26e Fast-forward docs/metadata-workflow.rst | 6 ++- swh/indexer/metadata.py | 10 +++-- swh/indexer/metadata_detector.py | 4 +- swh/indexer/metadata_dictionary/__init__.py | 12 +++++- swh/indexer/metadata_dictionary/base.py | 59 +++++++++++++++++------------ swh/indexer/metadata_dictionary/cff.py | 10 ++--- swh/indexer/metadata_dictionary/codemeta.py | 4 +- swh/indexer/metadata_dictionary/composer.py | 4 +- swh/indexer/metadata_dictionary/github.py | 12 ++---- swh/indexer/metadata_dictionary/maven.py | 4 +- swh/indexer/metadata_dictionary/npm.py | 4 +- swh/indexer/metadata_dictionary/python.py | 4 +- swh/indexer/metadata_dictionary/ruby.py | 11 ++---- 13 files changed, 78 insertions(+), 66 deletions(-) Changes applied before testcommit d41f26eef0561fd41932eb688bc6908f2253ef4c Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Mon Jul 4 13:37:58 2022 +0200 Use separate base classes for intrinsic and extrinsic mappings detect_metadata_files and extrinsic_metadata_formats (respectively) are somewhat mutually exclusive, so it does not make much sense to have them in the same class and MAPPINGS dict commit c2742b5b75f62a550ee905699cd47b5b13eac52a Author: Valentin Lorentz <vlorentz@softwareheritage.org> Date: Mon Jul 4 13:03:17 2022 +0200 cff: Remove redundant @context setting It is already set by _translate_dict itself. See https://jenkins.softwareheritage.org/job/DCIDX/job/tests-on-diff/335/ for more details. Harbormaster completed remote builds in B30261: Diff 29171.Jul 5 2022, 3:57 PM2022-07-05 15:57:31 (UTC+2) This revision is now accepted and ready to land.Jul 6 2022, 3:58 PM2022-07-06 15:58:27 (UTC+2) vlorentz added a child revision: D8082: Document codemeta.make_absolute_uri().Jul 6 2022, 4:05 PM2022-07-06 16:05:05 (UTC+2) Closed by commit rDCIDXd41f26eef056: Use separate base classes for intrinsic and extrinsic mappings (authored by vlorentz). · Explain WhyJul 11 2022, 5:21 PM2022-07-11 17:21:27 (UTC+2) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 29139 docs/metadata-workflow.rst
swh/indexer/metadata.py
swh/indexer/metadata_detector.py
swh/indexer/metadata_dictionary/__init__.py
|