Add a Storage.flavor property to the postgresql backend
ClosedPublic
Actions

Authored by douardda on Jul 1 2022, 3:04 PM.

Details

Reviewers

Group Reviewers

Commits

rDSTO47caf04ea5e9: Add a Storage.flavor property to the postgresql backend
rDSTOa00650ea0c34: Update pytest_plugin for swh.core 2.10

Summary

Add a Storage.flavor property to the postgresql backend

and add tests for 'mirror' and 'read_replica' flavors.

Depends on D8066.

Test Plan

tox (failing since it needs that diff ^ landed and a bump from swh.core)

Diff Detail

Repository

rDSTO Storage manager

Branch

flavor

Lint

Lint Skipped

Unit

Unit Tests Skipped

Build Status

Buildable 30200
Build 47203: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 47202: arc lint + arc unit

Event Timeline

douardda created this revision.Jul 1 2022, 3:04 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJul 1 2022, 3:04 PM

Build has FAILED

Patch application report for D8067 (id=29108)

Rebasing onto c19f53f194...

Current branch diff-target is up to date.

Changes applied before test

commit 47caf04ea5e9d47c976200fff7d61164985a4390
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 1 14:56:47 2022 +0200

    Add a Storage.flavor property to the postgresql backend
    
    and add tests for 'mirror' and 'read_replica' flavors.

commit a00650ea0c34a98653d24693ce07555f55d816f4
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 1 14:50:28 2022 +0200

    Update pytest_plugin for swh.core 2.10

Link to build: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1623/
See console output for more information: https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1623/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 1 2022, 3:15 PM

Harbormaster failed remote builds in B30200: Diff 29108!

douardda retitled this revision from Update pytest_plugin for swh.core 2.10 to Add a Storage.flavor property to the postgresql backend.Jul 1 2022, 5:53 PM

douardda mentioned this in D8068: Do not always auto-create an OriginVisitStatus object in origin_visit_add().Jul 1 2022, 5:53 PM

douardda mentioned this in D8066: Add the 'flavor' argument to db_utils.initialize_database_for_module().Jul 4 2022, 11:00 AM

ardumont edited the test plan for this revision. (Show Details)Jul 4 2022, 11:43 AM

ardumont added a subscriber: ardumont.Jul 4 2022, 12:01 PM

ardumont added inline comments.

swh/storage/tests/test_postgresql.py
29	So this one passes through the other property path (in the implem').

lgtm, one suggestion inline.

ardumont added inline comments.Jul 5 2022, 2:56 PM

requirements-swh.txt
1

Build is green

Patch application report for D8067 (id=29108)

Rebasing onto c19f53f194...

Current branch diff-target is up to date.

Changes applied before test

commit 47caf04ea5e9d47c976200fff7d61164985a4390
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 1 14:56:47 2022 +0200

    Add a Storage.flavor property to the postgresql backend
    
    and add tests for 'mirror' and 'read_replica' flavors.

commit a00650ea0c34a98653d24693ce07555f55d816f4
Author: David Douard <david.douard@sdfa3.org>
Date:   Fri Jul 1 14:50:28 2022 +0200

    Update pytest_plugin for swh.core 2.10

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1625/ for more details.

Harbormaster completed remote builds in B30200: Diff 29108.Jul 5 2022, 3:05 PM

douardda requested review of this revision.Jul 5 2022, 3:05 PM

lgtm (i've triggered back the build)

one requirement change suggested inline.

This revision is now accepted and ready to land.Jul 5 2022, 3:08 PM

ardumont added inline comments.Jul 5 2022, 3:09 PM