Differential D8008

Set object id when calling objstorage.add
ClosedPublic
Actions

Authored by olasd on Jun 21 2022, 2:35 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Maniphest Tasks

T2309: Add support for other hash algo than sha1 in current objstorage implementation

Commits

rDDATASETe31bdb26a827: Set object id when calling objstorage.add

Summary

We are removing support for the objstorage computing the object id itself.

Related to T2309

Diff Detail

Repository

rDDATASET Datasets

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 29948
Build 46818: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 46817: arc lint + arc unit

Event Timeline

olasd created this revision.Jun 21 2022, 2:35 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJun 21 2022, 2:35 PM

Build is green

Patch application report for D8008 (id=28861)

Rebasing onto 5916d8b5fc...

Current branch diff-target is up to date.

Changes applied before test

commit e31bdb26a8278e427a877ee1a5dd4ae8c0600124
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Tue Jun 21 14:35:03 2022 +0200

    Set object id when calling objstorage.add
    
    We are removing support for the objstorage computing the object id itself.

See https://jenkins.softwareheritage.org/job/DDATASET/job/tests-on-diff/146/ for more details.

Harbormaster completed remote builds in B29948: Diff 28861.Jun 21 2022, 2:38 PM

olasd requested review of this revision.Jun 21 2022, 2:38 PM

vlorentz accepted this revision.Jun 21 2022, 2:39 PM

This revision is now accepted and ready to land.Jun 21 2022, 2:39 PM

Closed by commit rDDATASETe31bdb26a827: Set object id when calling objstorage.add (authored by olasd). · Explain WhyJun 21 2022, 4:03 PM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDDATASETe31bdb26a827: Set object id when calling objstorage.add.