Updating e1a1d84..3c346da
Fast-forward
 swh/core/db/db_utils.py       |  9 +++++++++
 swh/core/db/tests/conftest.py | 13 +++++++++++++
 swh/core/db/tests/test_cli.py | 23 +++++++++++++++++++++++
 3 files changed, 45 insertions(+)

Changes applied before test

commit 3c346da3a9820917a6677f1b371ffa6a3d89b8d6
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Jun 8 10:46:09 2022 +0200

    Add missing coverage on `swh db version` cli
    
    Discovered when working on [1].
    
    Related to T4228
    
    [1] D7949

commit 47d9e8e22fa6c88eadbd552eebfbc42e51f72813
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Tue May 31 09:18:03 2022 +0200

    db: Grant read access to guest user on all schema tables
    
    This now automatically grant read-only access to the guest user at db initialization or
    upgrade time. This way, sysadm no longer have to manually alter the schema after
    initialization or upgrade.
    
    Related to T4228

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/446/ for more details.

Harbormaster completed remote builds in B29792: Diff 28710.Jun 8 2022, 10:49 AM

ardumont requested review of this revision.Jun 8 2022, 10:49 AM

ardumont mentioned this in D7949: db.BaseDb: Propose default get_current_version method implementation.Jun 8 2022, 11:21 AM

vlorentz accepted this revision.Jun 8 2022, 1:22 PM

This revision is now accepted and ready to land.Jun 8 2022, 1:22 PM

vlorentz requested changes to this revision.Jun 8 2022, 1:24 PM

vlorentz added inline comments.

swh/core/db/tests/test_cli.py
354	"order by dbversion"? shouldn't it be "order by version"?

This revision now requires changes to proceed.Jun 8 2022, 1:24 PM

ardumont added inline comments.Jun 8 2022, 2:39 PM

swh/core/db/tests/test_cli.py
354	yes

Fix typo

Build is green

Patch application report for D7968 (id=28722)

Rebasing onto 47d9e8e22f...

Current branch diff-target is up to date.

Changes applied before test

commit 5644f9cd33dabb5292988ccd9cd767fd52a9a069
Author: Antoine R. Dumont (@ardumont) <antoine.romain.dumont@gmail.com>
Date:   Wed Jun 8 10:46:09 2022 +0200

    Add missing coverage on `swh db version` cli
    
    Discovered when working on [1].
    
    Related to T4228
    
    [1] D7949

See https://jenkins.softwareheritage.org/job/DCORE/job/tests-on-diff/447/ for more details.

Harbormaster completed remote builds in B29803: Diff 28722.Jun 8 2022, 2:42 PM

ardumont marked an inline comment as done.Jun 8 2022, 3:27 PM

vlorentz accepted this revision.Jun 9 2022, 2:46 PM

This revision is now accepted and ready to land.Jun 9 2022, 2:46 PM

Closed by commit rDCORE5644f9cd33da: Add missing coverage on `swh db version` cli (authored by ardumont). · Explain WhyJun 9 2022, 2:55 PM

This revision was automatically updated to reflect the committed changes.

ardumont added a commit: rDCORE5644f9cd33da: Add missing coverage on `swh db version` cli.