Differential D7848

add_forge_now: Harmonize moderator permission management
ClosedPublic
Actions

Authored by anlambert on May 18 2022, 1:39 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T4254: [Add forge now] missing contact info

Commits

rDWAPPSb548d2f261ab: add_forge_now: Harmonize moderator permission management

Summary

Ensure staff users are considered as add forge now moderators.

Rename has_add_forge_now_permission function to is_add_forge_now_moderator
and move it to swh.web.auth.utils module.

Related to T4254

Diff Detail

Repository

rDWAPPS Web applications

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

anlambert created this revision.May 18 2022, 1:39 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 18 2022, 1:39 PM

Build is green

Patch application report for D7848 (id=28348)

Rebasing onto f2d6fec278...

Current branch diff-target is up to date.

Changes applied before test

commit b548d2f261abe15792a5c207f7258ba4adc0e366
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Wed May 18 13:35:39 2022 +0200

    add_forge_now: Harmonize moderator permission management
    
    Ensure staff users are considered as add forge now moderators.
    
    Rename has_add_forge_now_permission function to is_add_forge_now_moderator
    and move it to swh.web.auth.utils module.
    
    Related to T4254

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1848/ for more details.

Harbormaster completed remote builds in B29449: Diff 28348.May 18 2022, 2:00 PM

anlambert requested review of this revision.May 18 2022, 2:00 PM

ardumont accepted this revision.May 18 2022, 2:29 PM

This revision is now accepted and ready to land.May 18 2022, 2:29 PM

Closed by commit rDWAPPSb548d2f261ab: add_forge_now: Harmonize moderator permission management (authored by anlambert). · Explain WhyMay 18 2022, 3:21 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSb548d2f261ab: add_forge_now: Harmonize moderator permission management.