Differential D7747

api/origin_search: Add missing doc for visit_type query parameter
ClosedPublic
Actions

Authored by anlambert on May 5 2022, 5:14 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDWAPPSe6a8303eef64: api/origin_search: Add missing doc for visit_type query parameter

Summary

This was missed when the search by visit type feature was implemented.

Diff Detail

Repository

rDWAPPS Web applications

Branch

api-origin-search-add-visit-type-doc

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 29135
Build 45549: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 45548: arc lint + arc unit

Event Timeline

anlambert created this revision.May 5 2022, 5:14 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMay 5 2022, 5:14 PM

Build is green

Patch application report for D7747 (id=28016)

Rebasing onto 468dda170e...

Current branch diff-target is up to date.

Changes applied before test

commit 00c77e4799590b9776d1f842261054a0f6335804
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu May 5 17:13:08 2022 +0200

    api/origin_search: Add missing doc for visit_type query parameter
    
    This was missed when the search by visit type feature was implemented.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1780/ for more details.

Harbormaster completed remote builds in B29092: Diff 28016.May 5 2022, 5:34 PM

anlambert requested review of this revision.May 5 2022, 5:34 PM

vlorentz accepted this revision.May 6 2022, 1:29 PM

vlorentz added a subscriber: vlorentz.

vlorentz added inline comments.

swh/web/api/views/origin.py
154–157	I'd do it like this, but no big deal

This revision is now accepted and ready to land.May 6 2022, 1:29 PM

Rebase and improve code

Build is green

Patch application report for D7747 (id=28064)

Rebasing onto 54e679c461...

Current branch diff-target is up to date.

Changes applied before test

commit e6a8303eef6478b9350a2ff1b0f9abf4be9c856c
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Thu May 5 17:13:08 2022 +0200

    api/origin_search: Add missing doc for visit_type query parameter
    
    This was missed when the search by visit type feature was implemented.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1791/ for more details.

Harbormaster completed remote builds in B29135: Diff 28064.May 6 2022, 2:39 PM

Closed by commit rDWAPPSe6a8303eef64: api/origin_search: Add missing doc for visit_type query parameter (authored by anlambert). · Explain WhyMay 6 2022, 2:57 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPSe6a8303eef64: api/origin_search: Add missing doc for visit_type query parameter.