Page MenuHomeSoftware Heritage

Add a 'lister_name' argument to all tasks created from ListedOrigin
ClosedPublic

Authored by vlorentz on Apr 21 2022, 12:38 PM.

Details

Summary

This will allow loaders to guess the forge type, and use the right
API to fetch extrinsic metadata for the origin from the forge.

Diff Detail

Repository
rDSCH Scheduling utilities
Branch
task-lister-name
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 28624
Build 44743: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 44742: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D7621 (id=27597)

Could not rebase; Attempt merge onto a76bb02f0e...

Auto-merging swh/scheduler/celery_backend/recurrent_visits.py
Merge made by the 'recursive' strategy.
 swh/scheduler/backend.py                         |  16 ++
 swh/scheduler/celery_backend/recurrent_visits.py |   6 +-
 swh/scheduler/cli/origin.py                      |   8 +-
 swh/scheduler/interface.py                       |   4 +
 swh/scheduler/model.py                           |   9 -
 swh/scheduler/simulator/__init__.py              |   7 +-
 swh/scheduler/tests/test_api_client.py           |   1 +
 swh/scheduler/tests/test_model.py                |  33 ----
 swh/scheduler/tests/test_scheduler.py            |  21 +++
 swh/scheduler/tests/test_utils.py                | 225 ++++++++++++++++-------
 swh/scheduler/utils.py                           |  41 ++++-
 11 files changed, 257 insertions(+), 114 deletions(-)
Changes applied before test
commit bf074ac149486f97b3fc2a12dade9873e5e36dbd
Merge: a76bb02 2b6f824
Author: Jenkins user <jenkins@localhost>
Date:   Thu Apr 21 10:38:48 2022 +0000

    Merge branch 'diff-target' into HEAD

commit 2b6f824d1aa0742540d5fee1e5609a373be4d79a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 21 12:22:03 2022 +0200

    Add a 'lister_name' argument to all tasks created from ListedOrigin
    
    This will allow loaders to guess the forge type, and use the right
    API to fetch extrinsic metadata for the origin from the forge.

commit a89f124ac25485ca92946bbee6bf56398e25023f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 21 11:22:48 2022 +0200

    Make create_origin_task_dict a standalone function
    
    It feels off as a method method; and I am going to make it use joins
    in a future commit, so it makes more sense this way.

commit 0df5e61c4a153e2bfbf1e4a261a061999617f16c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 21 11:21:05 2022 +0200

    test_utils.py: Convert to pytest-style tests

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/532/ for more details.

This revision is now accepted and ready to land.Apr 21 2022, 2:43 PM

Build is green

Patch application report for D7621 (id=27617)

Rebasing onto 9483493ff5...

Current branch diff-target is up to date.
Changes applied before test
commit 8eae66baca3d79fa4397764fdec07f0025f31a38
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 21 12:22:03 2022 +0200

    Add a 'lister_name' argument to all tasks created from ListedOrigin
    
    This will allow loaders to guess the forge type, and use the right
    API to fetch extrinsic metadata for the origin from the forge.

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/536/ for more details.

This revision was landed with ongoing or failed builds.Apr 26 2022, 12:28 PM
This revision was automatically updated to reflect the committed changes.

Build is green

Patch application report for D7621 (id=27714)

Rebasing onto 0365b853fe...

First, rewinding head to replay your work on top of it...
Fast-forwarded diff-target to base-revision-541-D7621.
Changes applied before test

See https://jenkins.softwareheritage.org/job/DSCH/job/tests-on-diff/541/ for more details.