Differential D7522

Rename metadata_raw to raw_metadata in the private API
ClosedPublic
Actions

Authored by vlorentz on Apr 7 2022, 2:34 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDDEP56da78d0bf3b: Rename metadata_raw to raw_metadata in the private API

Summary

'metadata_raw' made sense, to discriminate from 'metadata_dict'; but no
longer does, now that the latter was removed.

Additionally, swh-web expects it to be named 'raw_metadata', so it
could never actually get the metadata.

Diff Detail

Repository

rDDEP Push deposit

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Apr 7 2022, 2:34 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptApr 7 2022, 2:34 PM

fix tests

ardumont published this revision for review.Apr 7 2022, 2:40 PM

ardumont accepted this revision.

This revision is now accepted and ready to land.Apr 7 2022, 2:40 PM

Build has FAILED

Patch application report for D7522 (id=27289)

Rebasing onto 6d1089cb25...

Current branch diff-target is up to date.

Changes applied before test

commit 4415b647ac1f3ff4f16e4fd338f60272a0418ebc
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 7 14:34:25 2022 +0200

    Rename metadata_raw to raw_metadata in the private API
    
    'metadata_raw' made sense, to discriminate from 'metadata_dict'; but no
    longer does, now that the latter was removed.
    
    Additionally, swh-web expects it to be named 'raw_metadata', so it
    could never actually get the metadata.

Link to build: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/830/
See console output for more information: https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/830/console

Harbormaster failed remote builds in B28220: Diff 27289!Apr 7 2022, 2:41 PM

Build is green

Patch application report for D7522 (id=27290)

Rebasing onto 6d1089cb25...

Current branch diff-target is up to date.

Changes applied before test

commit 56da78d0bf3b6f45ced055d7df644542e471299c
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Thu Apr 7 14:34:25 2022 +0200

    Rename metadata_raw to raw_metadata in the private API
    
    'metadata_raw' made sense, to discriminate from 'metadata_dict'; but no
    longer does, now that the latter was removed.
    
    Additionally, swh-web expects it to be named 'raw_metadata', so it
    could never actually get the metadata.

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/831/ for more details.

Harbormaster completed remote builds in B28221: Diff 27290.Apr 7 2022, 2:43 PM

Closed by commit rDDEP56da78d0bf3b: Rename metadata_raw to raw_metadata in the private API (authored by vlorentz). · Explain WhyApr 7 2022, 2:43 PM

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDDEP56da78d0bf3b: Rename metadata_raw to raw_metadata in the private API.

vlorentz mentioned this in T3939: Display metadata provenance in the deposit web ui.Apr 7 2022, 2:51 PM

ardumont mentioned this in T4125: Deploy deposit v1.0.Apr 8 2022, 10:55 AM

ardumont mentioned this in D7529: Rename metadata key in data received from the deposit server.