Page MenuHomeSoftware Heritage

inbound_email: split recipient matching logic out
ClosedPublic

Authored by olasd on Apr 4 2022, 5:04 PM.

Details

Summary

This allows calling the function on a single recipient rather than on a
whole message, when one isn't available.

Depends on D7497

Test Plan

Some simple tests have been added.

Diff Detail

Repository
rDWAPPS Web applications
Branch
inbound-email-recipient-logic
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 28132
Build 44064: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 44063: arc lint + arc unit

Event Timeline

Build is green

Patch application report for D7498 (id=27203)

Could not rebase; Attempt merge onto 902039b683...

Merge made by the 'recursive' strategy.
 requirements-test.txt                     |  2 +-
 swh/web/inbound_email/utils.py            | 39 ++++++++++++++++++++++---------
 swh/web/tests/inbound_email/test_utils.py | 19 +++++++++++++++
 3 files changed, 48 insertions(+), 12 deletions(-)
Changes applied before test
commit f7db1da8e193ae9e0d9ce6d93879d9f17c4ea4cc
Merge: 902039b6 104d8a87
Author: Jenkins user <jenkins@localhost>
Date:   Mon Apr 4 15:05:10 2022 +0000

    Merge branch 'diff-target' into HEAD

commit 104d8a87f09c8ed892d8dcf7af2ec08870e0b80e
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri Apr 1 15:16:11 2022 +0200

    inbound_email: split recipient matching logic out
    
    This allows calling the function on a single recipient rather than on a
    whole message, when one isn't available.

commit 30ea00efd7e0f2a34f7f70b1c6984fc743b82405
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri Apr 1 15:15:05 2022 +0200

    Restrict pytest-postgresql to < 4.0.0
    
    Other modules still need psycopg2 and pytest-postgresql 4 introduced a
    hard dependency on psycopg3.
    
    This restriction has only been needed since a recent dependency
    upgrade (or maybe a pip upgrade); pip has stopped being able to solve it
    itself for some reason.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1667/ for more details.

olasd requested review of this revision.Apr 4 2022, 5:27 PM
This revision is now accepted and ready to land.Apr 4 2022, 5:30 PM

Build was aborted

Patch application report for D7498 (id=27216)

Could not rebase; Attempt merge onto 902039b683...

Updating 902039b6..a594dd50
Fast-forward
 requirements-test.txt                     |  2 +-
 swh/web/inbound_email/utils.py            | 39 ++++++++++++++++++++++---------
 swh/web/tests/inbound_email/test_utils.py | 19 +++++++++++++++
 3 files changed, 48 insertions(+), 12 deletions(-)
Changes applied before test
commit a594dd506f581afddf1ca483ba49afe3e6695daf
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri Apr 1 15:16:11 2022 +0200

    inbound_email: split recipient matching logic out
    
    This allows calling the function on a single recipient rather than on a
    whole message, when one isn't available.

commit e46b75a9c5afe5ae58b67d1bf4a5c67e8363c1a0
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri Apr 1 15:15:05 2022 +0200

    Restrict pytest-postgresql to < 4.0.0
    
    Other modules still need psycopg2 and pytest-postgresql 4 introduced a
    hard dependency on psycopg3.
    
    This restriction has only been needed since a recent dependency
    upgrade (or maybe a pip upgrade); pip has stopped being able to solve it
    itself for some reason.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1671/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1671/console

This revision was landed with ongoing or failed builds.Apr 5 2022, 4:21 PM
This revision was automatically updated to reflect the committed changes.

Build was aborted

Patch application report for D7498 (id=27229)

Rebasing onto 2ad94111d6...

Current branch diff-target is up to date.
Changes applied before test
commit 10f8ba14679dc86d5039f581a58d31b1eb8b1b33
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Fri Apr 1 15:16:11 2022 +0200

    inbound_email: split recipient matching logic out
    
    This allows calling the function on a single recipient rather than on a
    whole message, when one isn't available.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1681/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1681/console