Page MenuHomeSoftware Heritage
Differential D7435

test_api_client.py: Also run tests from test_elasticsearch.py when possible
ClosedPublic
Actions

Authored by vlorentz on Mar 25 2022, 4:56 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Commits
rDSEAc0527d17b3bf: test_api_client.py: Also run tests from test_elasticsearch.py when possible
Summary

In addition to test_search.py, which do not include search QL tests

Depends on D7436 (which fixes a bug that would be caught by one of these tests).

Diff Detail

Unit TestsFailed
View All

TimeTest
358 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.search.tests.test_api_client.TestRemoteSearch::test_query_syntax_error
self = <swh.search.tests.test_api_client.TestRemoteSearch testMethod=test_query_syntax_error> def test_query_syntax_error(self):
7 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.search.in_memory::swh.search.in_memory._nested_get
15,543 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.search.tests.test_api_client.TestRemoteSearch::test_filter_keyword_in_filter
2,483 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.search.tests.test_api_client.TestRemoteSearch::test_journal_client_origin_visit_status_permutation
862 msJenkins > .tox.py3.lib.python3.7.site-packages.swh.search.tests.test_api_client.TestRemoteSearch::test_origin_instrinsic_metadata_dates_filter_sorting_search
View Full Test Results (1 Failed · 187 Passed · 1 Skipped)

Event Timeline

vlorentz created this revision.Mar 25 2022, 4:56 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 25 2022, 4:56 PM
vlorentz added a child revision: D7436: server: Return SearchQuerySyntaxError as 400 instead of 500.Mar 25 2022, 4:57 PM
swh-public-ci added a comment.Mar 25 2022, 5:00 PM

Build has FAILED

Patch application report for D7435 (id=26919)

Rebasing onto d273b070b0...

First, rewinding head to replay your work on top of it...
Applying: test_api_client.py: Also run tests from test_elasticsearch.py when possible
Changes applied before test
commit 772cab9045114e7a1cd77df366339b167391cd9a
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 25 16:55:49 2022 +0100

    test_api_client.py: Also run tests from test_elasticsearch.py when possible
    
    In addition to test_search.py, which do not include search QL tests

Link to build: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/314/
See console output for more information: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/314/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 25 2022, 5:00 PM
Harbormaster failed remote builds in B27836: Diff 26919!
vlorentz updated this revision to Diff 26921.Mar 25 2022, 5:18 PM

unstage a hunk

swh-public-ci added a comment.Mar 25 2022, 5:22 PM

Build has FAILED

Patch application report for D7435 (id=26921)

Rebasing onto d273b070b0...

First, rewinding head to replay your work on top of it...
Applying: test_api_client.py: Also run tests from test_elasticsearch.py when possible
Changes applied before test
commit 91b594bb0da5055bf8f54a940a3476c20b27197d
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 25 16:55:49 2022 +0100

    test_api_client.py: Also run tests from test_elasticsearch.py when possible
    
    In addition to test_search.py, which do not include search QL tests

Link to build: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/316/
See console output for more information: https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/316/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 25 2022, 5:22 PM
Harbormaster failed remote builds in B27838: Diff 26921!
vlorentz removed a child revision: D7436: server: Return SearchQuerySyntaxError as 400 instead of 500.Mar 25 2022, 5:31 PM
vlorentz edited the summary of this revision. (Show Details)
vlorentz added a parent revision: D7436: server: Return SearchQuerySyntaxError as 400 instead of 500.
vlorentz mentioned this in D7436: server: Return SearchQuerySyntaxError as 400 instead of 500.
vlorentz updated this revision to Diff 26925.Mar 25 2022, 5:32 PM

rebase

swh-public-ci added a comment.Mar 25 2022, 5:36 PM

Build is green

Patch application report for D7435 (id=26925)

Could not rebase; Attempt merge onto d273b070b0...

Merge made by the 'recursive' strategy.
 swh/search/api/server.py               |   6 +
 swh/search/tests/test_api_client.py    |   6 +-
 swh/search/tests/test_elasticsearch.py | 207 +++++++++++++++++----------------
 3 files changed, 115 insertions(+), 104 deletions(-)
Changes applied before test
commit 6bf7dbe1898cd9029b3df015c32fcc29fe8945b5
Merge: d273b07 9fd4e00
Author: Jenkins user <jenkins@localhost>
Date:   Fri Mar 25 16:32:47 2022 +0000

    Merge branch 'diff-target' into HEAD

commit 9fd4e0097ab88909cda05f3acb8deae292eec9eb
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 25 16:55:49 2022 +0100

    test_api_client.py: Also run tests from test_elasticsearch.py when possible
    
    In addition to test_search.py, which do not include search QL tests

commit b054bf85666fb3ccea0e6e0b1b76dd1633efd62e
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 25 16:56:51 2022 +0100

    server: Return SearchQuerySyntaxError as 400 instead of 500
    
    It is caused by a client error; and raising it as 500 prevents the RPC client
    from re-raising it using the right class.

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/320/ for more details.

Harbormaster completed remote builds in B27842: Diff 26925.Mar 25 2022, 5:36 PM
vlorentz requested review of this revision.Mar 25 2022, 5:36 PM
vlorentz updated this revision to Diff 26934.Mar 28 2022, 8:57 AM

rebase

swh-public-ci added a comment.Mar 28 2022, 9:02 AM

Build is green

Patch application report for D7435 (id=26934)

Rebasing onto 5483a038bb...

Current branch diff-target is up to date.
Changes applied before test
commit c0527d17b3bfac4c5414694eb4f22761973f3707
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 25 16:55:49 2022 +0100

    test_api_client.py: Also run tests from test_elasticsearch.py when possible
    
    In addition to test_search.py, which do not include search QL tests

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/322/ for more details.

Harbormaster completed remote builds in B27852: Diff 26934.Mar 28 2022, 9:02 AM
ardumont accepted this revision.Mar 28 2022, 1:41 PM
This revision is now accepted and ready to land.Mar 28 2022, 1:41 PM
Closed by commit rDSEAc0527d17b3bf: test_api_client.py: Also run tests from test_elasticsearch.py when possible (authored by vlorentz). · Explain WhyMar 29 2022, 10:40 AM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDSEAc0527d17b3bf: test_api_client.py: Also run tests from test_elasticsearch.py when possible.

Revision Contents
Changeset List

PathSize
swh/
search/
tests/
6 lines
207 lines

Diff 26921

View Options

swh/search/tests/test_api_client.py

Loading...
View Options

swh/search/tests/test_elasticsearch.py

Loading...
About · Developer information · Legal