Differential D7409

cypress: Fix flaky test
ClosedPublic
Actions

Authored by anlambert on Mar 22 2022, 4:46 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Commits

rDWAPPS716df4a9d7f7: cypress: Fix flaky test

Summary

This is an attempt to fix a cypress flaky test that happens quite often.

I will execute several Jenkins builds to see if these changes prevent it to happen.

Diff Detail

Repository

rDWAPPS Web applications

Branch

cypress-flaky-test-fix

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 27736
Build 43414: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 43413: arc lint + arc unit

Event Timeline

anlambert created this revision.Mar 22 2022, 4:46 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptMar 22 2022, 4:46 PM

Build is green

Patch application report for D7409 (id=26792)

Rebasing onto 74a5fc48c8...

Current branch diff-target is up to date.

Changes applied before test

commit 8e4f82c8dbe348fb1c5aa6b19bae15ab4130229f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Mar 22 16:42:49 2022 +0100

    cypress: Fix flaky test

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1539/ for more details.

Harbormaster completed remote builds in B27713: Diff 26792.Mar 22 2022, 5:05 PM

anlambert requested review of this revision.Mar 22 2022, 5:05 PM

Build is green

Patch application report for D7409 (id=26792)

Rebasing onto 74a5fc48c8...

Current branch diff-target is up to date.

Changes applied before test

commit 8e4f82c8dbe348fb1c5aa6b19bae15ab4130229f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Mar 22 16:42:49 2022 +0100

    cypress: Fix flaky test

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1540/ for more details.

Build is green

Patch application report for D7409 (id=26792)

Rebasing onto 74a5fc48c8...

Current branch diff-target is up to date.

Changes applied before test

commit 8e4f82c8dbe348fb1c5aa6b19bae15ab4130229f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Mar 22 16:42:49 2022 +0100

    cypress: Fix flaky test

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1541/ for more details.

ardumont accepted this revision.Mar 22 2022, 6:11 PM

This revision is now accepted and ready to land.Mar 22 2022, 6:11 PM

Build is green

Patch application report for D7409 (id=26792)

Rebasing onto 74a5fc48c8...

Current branch diff-target is up to date.

Changes applied before test

commit 8e4f82c8dbe348fb1c5aa6b19bae15ab4130229f
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Mar 22 16:42:49 2022 +0100

    cypress: Fix flaky test

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1542/ for more details.

Build is green

Patch application report for D7409 (id=26792)

Rebasing onto 2e4a9bf6f8...

First, rewinding head to replay your work on top of it...
Applying: cypress: Fix flaky test

Changes applied before test

commit 0e20cf4c3ca5a8c6fd5b0b78c5857ecd1b19b6d9
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Mar 22 16:42:49 2022 +0100

    cypress: Fix flaky test

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1546/ for more details.

Looks like it worked, will land then.

Rebase

Build is green

Patch application report for D7409 (id=26815)

Rebasing onto 2e4a9bf6f8...

Current branch diff-target is up to date.

Changes applied before test

commit 716df4a9d7f74c0ddf688405cbf9d61715d3e54a
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Mar 22 16:42:49 2022 +0100

    cypress: Fix flaky test

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1547/ for more details.

Harbormaster completed remote builds in B27736: Diff 26815.Mar 23 2022, 11:23 AM

Closed by commit rDWAPPS716df4a9d7f7: cypress: Fix flaky test (authored by anlambert). · Explain WhyMar 23 2022, 11:36 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS716df4a9d7f7: cypress: Fix flaky test.