Page MenuHomeSoftware Heritage
Differential D7291

Rewrite the server to use flask instead of aiohttp
ClosedPublic
Actions

Authored by vlorentz on Mar 4 2022, 11:08 AM.

Details

Reviewers
olasd
Group Reviewers
Reviewers
Maniphest Tasks
Restricted Maniphest Task
Commits
rDVAUdf35ac0601ff: Rewrite the server to use flask instead of aiohttp
Summary

The azure backend cannot be run in the same thread as an asyncio
event loop: https://forge.softwareheritage.org/T3981

Diff Detail

Event Timeline

vlorentz created this revision.Mar 4 2022, 11:08 AM
Herald added a reviewer: Reviewers. · View Herald TranscriptMar 4 2022, 11:08 AM
swh-public-ci added a comment.Mar 4 2022, 11:11 AM

Build has FAILED

Patch application report for D7291 (id=26388)

Rebasing onto 252aa1464d...

Current branch diff-target is up to date.
Changes applied before test
commit 8f8da1887dd35a0921791bdfd50dd6b648f48757
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 4 11:08:31 2022 +0100

    Rewrite the server to use flask instead of aiohttp
    
    The azure backend cannot be run in the same thread as an asyncio
    event loop: https://forge.softwareheritage.org/T3981

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/218/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/218/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 4 2022, 11:11 AM
Harbormaster failed remote builds in B27274: Diff 26388!
vlorentz updated this revision to Diff 26392.Mar 4 2022, 12:26 PM

remove create_app(), for consistency

swh-public-ci added a comment.Mar 4 2022, 12:29 PM

Build has FAILED

Patch application report for D7291 (id=26392)

Rebasing onto 252aa1464d...

Current branch diff-target is up to date.
Changes applied before test
commit 2a80c26d2e902984eaef0c1fd3393f3eb73c9c87
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 4 11:08:31 2022 +0100

    Rewrite the server to use flask instead of aiohttp
    
    The azure backend cannot be run in the same thread as an asyncio
    event loop: https://forge.softwareheritage.org/T3981

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/219/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/219/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 4 2022, 12:29 PM
Harbormaster failed remote builds in B27278: Diff 26392!
vlorentz updated this revision to Diff 26393.Mar 4 2022, 12:34 PM

remove debug code

swh-public-ci added a comment.Mar 4 2022, 12:37 PM

Build has FAILED

Patch application report for D7291 (id=26393)

Rebasing onto 252aa1464d...

Current branch diff-target is up to date.
Changes applied before test
commit 2df5faf7622831a3576d3db5687914e620fe8c9f
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 4 11:08:31 2022 +0100

    Rewrite the server to use flask instead of aiohttp
    
    The azure backend cannot be run in the same thread as an asyncio
    event loop: https://forge.softwareheritage.org/T3981

Link to build: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/220/
See console output for more information: https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/220/console

Harbormaster returned this revision to the author for changes because remote builds failed.Mar 4 2022, 12:37 PM
Harbormaster failed remote builds in B27279: Diff 26393!
olasd added a child revision: D7292: Ensure server tests and fixtures properly clean up the global flask app.Mar 4 2022, 12:58 PM
vlorentz updated this revision to Diff 26395.Mar 4 2022, 1:20 PM
vlorentz added a subscriber: olasd.

fixup with @olasd's patch

swh-public-ci added a comment.Mar 4 2022, 1:22 PM

Build is green

Patch application report for D7291 (id=26395)

Rebasing onto 252aa1464d...

Current branch diff-target is up to date.
Changes applied before test
commit df35ac0601ff2685506a685205582a39333fd9a4
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Fri Mar 4 11:08:31 2022 +0100

    Rewrite the server to use flask instead of aiohttp
    
    The azure backend cannot be run in the same thread as an asyncio
    event loop: https://forge.softwareheritage.org/T3981

See https://jenkins.softwareheritage.org/job/DVAU/job/tests-on-diff/222/ for more details.

Harbormaster completed remote builds in B27282: Diff 26395.Mar 4 2022, 1:22 PM
vlorentz requested review of this revision.Mar 4 2022, 1:22 PM
olasd accepted this revision.Mar 4 2022, 1:26 PM

Great, thanks!

This revision is now accepted and ready to land.Mar 4 2022, 1:26 PM
olasd mentioned this in D7292: Ensure server tests and fixtures properly clean up the global flask app.Mar 4 2022, 1:26 PM
Closed by commit rDVAUdf35ac0601ff: Rewrite the server to use flask instead of aiohttp (authored by vlorentz). · Explain WhyMar 4 2022, 1:27 PM
This revision was automatically updated to reflect the committed changes.
vlorentz added a commit: rDVAUdf35ac0601ff: Rewrite the server to use flask instead of aiohttp.
vlorentz added a task: Restricted Maniphest Task.Mar 7 2022, 9:25 AM

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
vault/
api/
72 lines96%
Loading...
tests/
76 lines100%
Loading...

Diff 26395

View Options

swh/vault/api/server.py

Loading...
View Options

swh/vault/tests/test_server.py

Loading...
About · Developer information · Legal