Page MenuHomeSoftware Heritage
Differential D7257

swh.deposit.client: Fix unparsable error response
ClosedPublic
Actions

Authored by ardumont on Feb 25 2022, 2:15 PM.

Details

Reviewers
None
Group Reviewers
Reviewers
Commits
rDDEP2c6e56caa062: swh.deposit.client: Fix unparsable error response
Summary

That can happen... when providing the wrong input.
404 returns html content and not xml for example.

Test Plan

existing tests ok, that particular conditional is missing though but i'm lazy right now.

Diff Detail

Repository
rDDEP Push deposit
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 27171
Build 42501: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 42500: arc lint + arc unit

Event Timeline

ardumont created this revision.Feb 25 2022, 2:15 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptFeb 25 2022, 2:15 PM
swh-public-ci added a comment.Feb 25 2022, 2:21 PM

Build is green

Patch application report for D7257 (id=26291)

Rebasing onto ccff46762b...

Current branch diff-target is up to date.
Changes applied before test
commit 21d4a9c75c1548e4657f9accccb584e0085c0f04
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Feb 25 13:55:03 2022 +0100

    swh.deposit.client: Fix unparsable error response

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/778/ for more details.

Harbormaster completed remote builds in B27164: Diff 26291.Feb 25 2022, 2:21 PM
ardumont requested review of this revision.Feb 25 2022, 2:21 PM
vlorentz added a subscriber: vlorentz.Feb 25 2022, 6:53 PM

Shouldn't this pint the reponse?

ardumont edited the test plan for this revision. (Show Details)Feb 25 2022, 6:53 PM

Shouldn't this pint the reponse?

maybe, yes, in the warning, you mean?

vlorentz added a comment.Feb 25 2022, 10:12 PM

yes

ardumont updated this revision to Diff 26298.Feb 26 2022, 12:51 PM

Print unparsable response text in (warning) log

swh-public-ci added a comment.Feb 26 2022, 12:57 PM

Build is green

Patch application report for D7257 (id=26298)

Rebasing onto ccff46762b...

Current branch diff-target is up to date.
Changes applied before test
commit 9ae4055e3420ab064d630ab46c7a0ae827427435
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Feb 25 13:55:03 2022 +0100

    swh.deposit.client: Fix unparsable error response

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/779/ for more details.

Harbormaster completed remote builds in B27171: Diff 26298.Feb 26 2022, 12:57 PM
ardumont updated this revision to Diff 26438.Mar 7 2022, 6:03 PM

Rebase from the correct repository

swh-public-ci added a comment.Mar 7 2022, 6:09 PM

Build is green

Patch application report for D7257 (id=26438)

Rebasing onto 5271378581...

Current branch diff-target is up to date.
Changes applied before test
commit ddfeadcb62b67e214cd7f7aa99948a0e39bc7309
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Feb 25 13:55:03 2022 +0100

    swh.deposit.client: Fix unparsable error response

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/794/ for more details.

Harbormaster completed remote builds in B27325: Diff 26438.Mar 7 2022, 6:09 PM
ardumont updated this revision to Diff 26451.Mar 8 2022, 4:15 PM

Rebase

swh-public-ci added a comment.Mar 8 2022, 4:21 PM

Build is green

Patch application report for D7257 (id=26451)

Rebasing onto 1fe5bf1913...

Current branch diff-target is up to date.
Changes applied before test
commit 2c6e56caa062d24fb7648a23ca80790431cbaa63
Author: Antoine R. Dumont (@ardumont) <ardumont@softwareheritage.org>
Date:   Fri Feb 25 13:55:03 2022 +0100

    swh.deposit.client: Fix unparsable error response

See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/797/ for more details.

Harbormaster completed remote builds in B27336: Diff 26451.Mar 8 2022, 4:21 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2022, 4:38 PM
Closed by commit rDDEP2c6e56caa062: swh.deposit.client: Fix unparsable error response (authored by ardumont). · Explain Why
This revision was automatically updated to reflect the committed changes.
ardumont added a commit: rDDEP2c6e56caa062: swh.deposit.client: Fix unparsable error response.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
deposit/
9 lines95%
Loading...

Diff 26298

View Options

swh/deposit/client.py

Loading...
About · Developer information · Legal