Incremental Person fullname normalization changes
ClosedPublic
Actions

Authored by olasd on Jan 31 2022, 10:08 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDSTOf868f3c8ad46: Mostly use normalized Person objects in tests
rDSTOd4ddd41535d0: postgresql: Use Person.from_fullname if name and email are None

Summary

Two commits:

postgresql: Use Person.from_fullname if name and email are None
Mostly use normalized Person objects in tests

The first commit allows us to populate sensible name and email values out of the
new displayname field, without having to store them.

The second commit opens up the possibility of eventually ignoring the name and
email fields stored in database in favor of parsing them again from the
fullname field (and therefore to update our parsing logic without having to
affect stored data).

Test Plan

unit tests/data fixed up

Diff Detail

Repository

rDSTO Storage manager

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

olasd created this revision.Jan 31 2022, 10:08 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 31 2022, 10:08 PM

olasd mentioned this in D7051: Introduce a new displayname field for persons in the PostgreSQL storage.Jan 31 2022, 10:09 PM

olasd added a child revision: D7051: Introduce a new displayname field for persons in the PostgreSQL storage.Jan 31 2022, 10:09 PM

Build is green

Patch application report for D7053 (id=25579)

Rebasing onto 6f0252465c...

Current branch diff-target is up to date.

Changes applied before test

commit f868f3c8ad46d4e9bd53ee800ba26bb03443b705
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Jan 31 20:09:43 2022 +0100

    Mostly use normalized Person objects in tests
    
    This opens up the possibility of eventually ignoring the `name` and
    `email` fields stored in database in favor of parsing them again from
    the fullname field (and therefore to update our parsing logic without
    having to affect stored data).

commit d4ddd41535d0ce1cd50d51d297e154bf0ab6e649
Author: Nicolas Dandrimont <nicolas@dandrimont.eu>
Date:   Mon Jan 31 20:08:04 2022 +0100

    postgresql: Use Person.from_fullname if name and email are None
    
    This allows us to populate sensible name and email values out of the new
    displayname field, without having to store them.

See https://jenkins.softwareheritage.org/job/DSTO/job/tests-on-diff/1544/ for more details.

Harbormaster completed remote builds in B26411: Diff 25579.Jan 31 2022, 10:16 PM

olasd requested review of this revision.Jan 31 2022, 10:16 PM

vlorentz accepted this revision.Jan 31 2022, 10:18 PM

This revision is now accepted and ready to land.Jan 31 2022, 10:18 PM

Closed by commit rDSTOd4ddd41535d0: postgresql: Use Person.from_fullname if name and email are None (authored by olasd). · Explain WhyFeb 1 2022, 10:28 AM

This revision was automatically updated to reflect the committed changes.

olasd added a commit: rDSTOd4ddd41535d0: postgresql: Use Person.from_fullname if name and email are None.

olasd added a commit: rDSTOf868f3c8ad46: Mostly use normalized Person objects in tests.