Paths

Table of Contentst

Differential D6919

api/graph: Handle query parameters that might be passed in graph_query
ClosedPublic
Actions

Authored by anlambert on Jan 11 2022, 5:47 PM.

Details

Reviewers

seirl

Group Reviewers

Reviewers

Commits

rDWAPPS9e7732ccebe3: api/graph: Handle query parameters that might be passed in graph_query

Summary

It is possible to pass query parameters in the graph_query URL argument
of the Web API graph endpoint if the ? character is quoted.

So add extra processing in the endpoint implementation to merge the
query parameters extracted from the graph_query value and those
coming from the django request.

The purpose is to avoid some query parameters to be silently ignored
when requesting the graph API.

Diff Detail

Repository

rDWAPPS Web applications

Branch

api-graph-query-params-in-graph-query

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25945
Build 40546: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 40545: arc lint + arc unit

Event Timeline

anlambert created this revision.Jan 11 2022, 5:47 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 11 2022, 5:47 PM

anlambert mentioned this in D6914: api/graph: Implement anti-DoS policies for graph visits.Jan 11 2022, 5:48 PM

Build is green

Patch application report for D6919 (id=25065)

Rebasing onto e0a181daf4...

Current branch diff-target is up to date.

Changes applied before test

commit 744c1daec3983870cb79a6e0c543e7b23760cc61
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jan 11 17:40:34 2022 +0100

    api/graph: Handle query parameters that might be passed in graph_query
    
    It is possible to pass query parameters in the graph_query URL argument
    of the Web API graph endpoint if the ? character is quoted.
    
    So add extra processing in the endpoint implementation to merge the
    query parameters extracted from the graph_query value and those
    coming from the django request.
    
    The purpose is to avoid some query parameters to be silently ignored
    when requesting the graph API.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1288/ for more details.

Harbormaster completed remote builds in B25940: Diff 25065.Jan 11 2022, 6:03 PM

anlambert requested review of this revision.Jan 11 2022, 6:03 PM

Rebase

anlambert added a child revision: D6914: api/graph: Implement anti-DoS policies for graph visits.Jan 12 2022, 11:06 AM

Build is green

Patch application report for D6919 (id=25070)

Rebasing onto 15e6e1988a...

Current branch diff-target is up to date.

Changes applied before test

commit 43525e69eaeb058b5d41c7031c422e7de088af16
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jan 11 17:40:34 2022 +0100

    api/graph: Handle query parameters that might be passed in graph_query
    
    It is possible to pass query parameters in the graph_query URL argument
    of the Web API graph endpoint if the ? character is quoted.
    
    So add extra processing in the endpoint implementation to merge the
    query parameters extracted from the graph_query value and those
    coming from the django request.
    
    The purpose is to avoid some query parameters to be silently ignored
    when requesting the graph API.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1289/ for more details.

Harbormaster completed remote builds in B25945: Diff 25070.Jan 12 2022, 11:16 AM

Minor comment to avoid doing url parsing manually, otherwise LGTM

swh/web/api/views/graph.py
151	I think it's cleaner to use `urlunparse()` here.

This revision now requires changes to proceed.Jan 12 2022, 2:17 PM

anlambert added inline comments.Jan 12 2022, 2:34 PM

swh/web/api/views/graph.py
151	Better indeed, thanks !

Use urlunparse.

seirl accepted this revision.Jan 12 2022, 2:50 PM

This revision is now accepted and ready to land.Jan 12 2022, 2:50 PM

Build is green

Patch application report for D6919 (id=25091)

Rebasing onto 15e6e1988a...

Current branch diff-target is up to date.

Changes applied before test

commit 9e7732ccebe33b7f4f37ad92a13998136580b2c9
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jan 11 17:40:34 2022 +0100

    api/graph: Handle query parameters that might be passed in graph_query
    
    It is possible to pass query parameters in the graph_query URL argument
    of the Web API graph endpoint if the ? character is quoted.
    
    So add extra processing in the endpoint implementation to merge the
    query parameters extracted from the graph_query value and those
    coming from the django request.
    
    The purpose is to avoid some query parameters to be silently ignored
    when requesting the graph API.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1294/ for more details.

Harbormaster completed remote builds in B25965: Diff 25091.Jan 12 2022, 2:51 PM

Closed by commit rDWAPPS9e7732ccebe3: api/graph: Handle query parameters that might be passed in graph_query (authored by anlambert). · Explain WhyJan 12 2022, 3:00 PM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS9e7732ccebe3: api/graph: Handle query parameters that might be passed in graph_query.