Differential D6918

api/graph: Forward error response from the graph API
ClosedPublic
Actions

Authored by anlambert on Jan 11 2022, 4:42 PM.

Details

Reviewers

vlorentz

Group Reviewers

Reviewers

Commits

rDWAPPS15e6e1988a56: api/graph: Forward error response from the graph API

Summary

If the request sent to the graph API returns an error, forward
the raw error response as the Web API response instead of trying
to parse a JSON response that usually fails.

Diff Detail

Repository

rDWAPPS Web applications

Branch

api-graph-error-handling

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25939
Build 40538: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 40537: arc lint + arc unit

Event Timeline

anlambert created this revision.Jan 11 2022, 4:42 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 11 2022, 4:42 PM

Build has FAILED

Patch application report for D6918 (id=25064)

Rebasing onto e0a181daf4...

Current branch diff-target is up to date.

Changes applied before test

commit 15e6e1988a5667631bfc1c9585b0d710e27ad6be
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jan 11 16:38:15 2022 +0100

    api/graph: Forward error response from the graph API
    
    If the request sent to the graph API returns an error, forward
    the raw error response as the Web API response instead of trying
    to parse a JSON response that usually fails.

Link to build: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1286/
See console output for more information: https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1286/console

Harbormaster returned this revision to the author for changes because remote builds failed.Jan 11 2022, 5:02 PM

Harbormaster failed remote builds in B25939: Diff 25064!

Build is green

Patch application report for D6918 (id=25064)

Rebasing onto e0a181daf4...

Current branch diff-target is up to date.

Changes applied before test

commit 15e6e1988a5667631bfc1c9585b0d710e27ad6be
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Tue Jan 11 16:38:15 2022 +0100

    api/graph: Forward error response from the graph API
    
    If the request sent to the graph API returns an error, forward
    the raw error response as the Web API response instead of trying
    to parse a JSON response that usually fails.

See https://jenkins.softwareheritage.org/job/DWAPPS/job/tests-on-diff/1287/ for more details.

Harbormaster completed remote builds in B25939: Diff 25064.Jan 11 2022, 5:22 PM

anlambert requested review of this revision.Jan 11 2022, 5:22 PM

vlorentz accepted this revision.Jan 11 2022, 5:25 PM

This revision is now accepted and ready to land.Jan 11 2022, 5:25 PM

anlambert mentioned this in D6914: api/graph: Implement anti-DoS policies for graph visits.Jan 11 2022, 5:48 PM

Closed by commit rDWAPPS15e6e1988a56: api/graph: Forward error response from the graph API (authored by anlambert). · Explain WhyJan 12 2022, 10:57 AM

This revision was automatically updated to reflect the committed changes.

anlambert added a commit: rDWAPPS15e6e1988a56: api/graph: Forward error response from the graph API.