Differential D6908

tests: Use TimestampWithTimezone.from_datetime() instead of the constructor
ClosedPublic
Actions

Authored by vlorentz on Jan 11 2022, 12:09 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Maniphest Tasks

T3752: Store/represent time offsets as strings

Commits

rDCNT7c3adff40cbb: tests: Use TimestampWithTimezone.from_datetime() instead of the constructor

Summary

A future release of swh-model will change its constructor's signature (replace 'offset'
and 'negative_utc_offset' with 'offset_bytes).

Diff Detail

Repository

rDCNT Archive counters

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Jan 11 2022, 12:09 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 11 2022, 12:09 PM

Build is green

Patch application report for D6908 (id=25046)

Rebasing onto db50e82178...

Current branch diff-target is up to date.

Changes applied before test

commit 7c3adff40cbb854feed28f236749eb3e299e4aed
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jan 11 12:09:29 2022 +0100

    tests: Use TimestampWithTimezone.from_datetime() instead of the constructor
    
    A future release of swh-model will change its constructor's signature (replace 'offset'
    and 'negative_utc_offset' with 'offset_bytes).

See https://jenkins.softwareheritage.org/job/DCNT/job/tests-on-diff/61/ for more details.

Harbormaster completed remote builds in B25916: Diff 25046.Jan 11 2022, 12:11 PM

vlorentz requested review of this revision.Jan 11 2022, 12:11 PM

vlorentz added a task: T3752: Store/represent time offsets as strings.Jan 11 2022, 2:15 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 11 2022, 3:29 PM

Closed by commit rDCNT7c3adff40cbb: tests: Use TimestampWithTimezone.from_datetime() instead of the constructor (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDCNT7c3adff40cbb: tests: Use TimestampWithTimezone.from_datetime() instead of the constructor.