Differential D6913

tests: Use TimestampWithTimezone.from_datetime() instead of the constructor
ClosedPublic
Actions

Authored by vlorentz on Jan 11 2022, 2:15 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Maniphest Tasks

T3752: Store/represent time offsets as strings

Commits

rDSEAc0140db7b504: tests: Use TimestampWithTimezone.from_datetime() instead of the constructor

Summary

A future release of swh-model will change its constructor's signature (replace 'offset'
and 'negative_utc_offset' with 'offset_bytes).

Diff Detail

Repository

rDSEA Archive search

Branch

master

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25925
Build 40519: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 40518: arc lint + arc unit

Event Timeline

vlorentz created this revision.Jan 11 2022, 2:15 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptJan 11 2022, 2:15 PM

vlorentz added a task: T3752: Store/represent time offsets as strings.Jan 11 2022, 2:15 PM

Build is green

Patch application report for D6913 (id=25056)

Rebasing onto b260c82475...

Current branch diff-target is up to date.

Changes applied before test

commit c0140db7b5045332b061983af2540bcf8ff8e3ad
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date:   Tue Jan 11 14:15:21 2022 +0100

    tests: Use TimestampWithTimezone.from_datetime() instead of the constructor
    
    A future release of swh-model will change its constructor's signature (replace 'offset'
    and 'negative_utc_offset' with 'offset_bytes).

See https://jenkins.softwareheritage.org/job/DSEA/job/tests-on-diff/304/ for more details.

Harbormaster completed remote builds in B25925: Diff 25056.Jan 11 2022, 2:19 PM

vlorentz requested review of this revision.Jan 11 2022, 2:19 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 11 2022, 3:29 PM

Closed by commit rDSEAc0140db7b504: tests: Use TimestampWithTimezone.from_datetime() instead of the constructor (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz added a commit: rDSEAc0140db7b504: tests: Use TimestampWithTimezone.from_datetime() instead of the constructor.