Not stripping them causes test failures (because of the unexpected
field) and crash in production (because bytes cannot be serialized to
JSON).
Resolves the two deposit failures in T3815.
Details
Details
- Reviewers
olasd - Group Reviewers
Reviewers - Maniphest Tasks
- T3815: Diagnose swh-environment build failures
- Commits
- rDDEPd2dfc416d177: Strip 'offset_bytes' from date dicts to support swh-model 4.0.0
Diff Detail
Diff Detail
- Repository
- rDDEP Push deposit
- Branch
- master
- Lint
No Linters Available - Unit
No Unit Test Coverage - Build Status
Buildable 25758 Build 40260: Phabricator diff pipeline on jenkins Jenkins console · Jenkins Build 40259: arc lint + arc unit
Event Timeline
Comment Actions
Build is green
Patch application report for D6867 (id=24881)
Rebasing onto 9807be11d0...
First, rewinding head to replay your work on top of it... Applying: Strip 'offset_bytes' from date dicts to support swh-model 4.0.0
Changes applied before test
commit ae3633f13b6fbef0402de42a15a969eab6ef2530
Author: Valentin Lorentz <vlorentz@softwareheritage.org>
Date: Tue Dec 21 12:01:56 2021 +0100
Strip 'offset_bytes' from date dicts to support swh-model 4.0.0
Not stripping them causes test failures (because of the unexpected
field) and crash in production (because bytes cannot be serialized to
JSON).See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/683/ for more details.
Comment Actions
Build is green
Patch application report for D6867 (id=24891)
Rebasing onto d2dfc416d1...
First, rewinding head to replay your work on top of it... Fast-forwarded diff-target to base-revision-684-D6867.
Changes applied before test
See https://jenkins.softwareheritage.org/job/DDEP/job/tests-on-diff/684/ for more details.