Differential D787

Remove mocks from range tests of mimetype and license indexers.
ClosedPublic
Actions

Authored by vlorentz on Dec 6 2018, 6:32 PM.

Details

Reviewers

None

Group Reviewers

Reviewers

Maniphest Tasks

T1307: Remove mock storages used in tests.

Commits

rDCIDXc2db74467ea6: Update CommonContentIndexerTest to work with non-mocked storage.

Summary

Also fix hash types and add type checks.

(Includes commits from D786)

Diff Detail

Repository

rDCIDX Metadata indexer

Branch

mimetypes-licenses-mock-ranges

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 2902
Build 3677: tox-on-jenkins	Jenkins
Build 3676: arc lint + arc unit

Event Timeline

vlorentz created this revision.Dec 6 2018, 6:32 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 6 2018, 6:32 PM

vlorentz added a parent revision: D786: Add content_fossology_license_get_range + Remove mock from non-range tests..Dec 6 2018, 6:32 PM

Build is green
See https://jenkins.softwareheritage.org/job/DCIDX/job/tox/131/ for more details.

Harbormaster completed remote builds in B2902: Diff 2480.Dec 6 2018, 6:35 PM

This revision was not accepted when it landed; it landed in state Needs Review.Dec 7 2018, 10:04 AM

Closed by commit rDCIDXc2db74467ea6: Update CommonContentIndexerTest to work with non-mocked storage. (authored by vlorentz). · Explain Why

This revision was automatically updated to reflect the committed changes.

vlorentz mentioned this in D788: Remove mocks from range tests of mimetype and license indexers..Dec 7 2018, 10:15 AM

vlorentz added a task: T1307: Remove mock storages used in tests..Dec 7 2018, 5:13 PM

Revision Contents
Changeset List

Path

Size

swh/

indexer/

fossology_license.py

1 line

indexer.py

9 lines

storage/

__init__.py

9 lines

in_memory.py

369 lines

tests/

storage/

test_in_memory.py

72 lines

test_ctags.py

13 lines

test_fossology_license.py

33 lines

test_mimetype.py

32 lines

test_utils.py

66 lines

Diff 2480

View Options

swh/indexer/fossology_license.py

View Options

swh/indexer/indexer.py

View Options

swh/indexer/storage/init.py

View Options

swh/indexer/storage/in_memory.py

View Options

swh/indexer/tests/storage/test_in_memory.py

View Options

swh/indexer/tests/test_ctags.py

View Options

swh/indexer/tests/test_fossology_license.py

View Options

swh/indexer/tests/test_mimetype.py

View Options

swh/indexer/tests/test_utils.py

Remove mocks from range tests of mimetype and license indexers.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 2480

swh/indexer/fossology_license.py

swh/indexer/indexer.py

swh/indexer/storage/__init__.py

swh/indexer/storage/in_memory.py

swh/indexer/tests/storage/test_in_memory.py

swh/indexer/tests/test_ctags.py

swh/indexer/tests/test_fossology_license.py

swh/indexer/tests/test_mimetype.py

swh/indexer/tests/test_utils.py

Remove mocks from range tests of mimetype and license indexers.
ClosedPublic
Actions

Revision Contents
Changeset List

swh/indexer/storage/init.py