Differential D780

Use the in-mem storage.
ClosedPublic
Actions

Authored by vlorentz on Dec 5 2018, 2:05 PM.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Commits

rDLDTARdade3ae571d8: Use the in-mem storage.

Summary

Diff Detail

Repository

rDLDTAR Tarball Loader

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

vlorentz created this revision.Dec 5 2018, 2:05 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptDec 5 2018, 2:05 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDTAR/job/tox/7/ for more details.

Harbormaster completed remote builds in B2860: Diff 2452.Dec 5 2018, 2:07 PM

ardumont added a subscriber: ardumont.Dec 5 2018, 2:13 PM

ardumont added inline comments.

swh/loader/tar/tests/test_loader.py
108	why do you have to flush explicitely? The loader-core's current behavior is supposed to do it. (for now loader-tar -inherits-> loader-dir -inherits-> loader-core, for now because i'd like to simplify this inheritance chain, never had a chance to ;)

vlorentz marked an inline comment as done.Dec 5 2018, 2:15 PM

vlorentz added inline comments.

swh/loader/tar/tests/test_loader.py
108	I don't. I was trying stuff and forgot to clean this

Remove useless call.

Harbormaster completed remote builds in B2862: Diff 2453.Dec 5 2018, 2:18 PM

Build is green
See https://jenkins.softwareheritage.org/job/DLDTAR/job/tox/36/ for more details.

ardumont accepted this revision.Dec 5 2018, 2:18 PM

This revision is now accepted and ready to land.Dec 5 2018, 2:18 PM

squash

Closed by commit rDLDTARdade3ae571d8: Use the in-mem storage. (authored by vlorentz). · Explain WhyDec 5 2018, 2:21 PM

This revision was automatically updated to reflect the committed changes.

Harbormaster failed remote builds in B2865: Diff 2456!Dec 5 2018, 2:22 PM

Build has FAILED

Link to build: https://jenkins.softwareheritage.org/job/DLDTAR/job/tox/37/
See console output for more information: https://jenkins.softwareheritage.org/job/DLDTAR/job/tox/37/console

Revision Contents
Changeset List

Path

Size

swh/

loader/

tar/

tests/

55 lines

Diff 2457

swh/loader/tar/tests/test_loader.py

Loading...