Page MenuHomeSoftware Heritage
Differential D6755

hashutil: Add support for md5 sum
ClosedPublic
Actions

Authored by anlambert on Dec 6 2021, 5:43 PM.

Details

Reviewers
ardumont
Group Reviewers
Reviewers
Maniphest Tasks
T2400: Ingest current and historical Ubuntu releases
Commits
rDMOD37364c24b509: hashutil: Add support for md5 sum
Summary

Enable to compute md5 sum through the hashutil.MultiHash class.

Nevertheless, md5 is not put in DEFAULT_ALGORITHMS set and must
be explicitely requested by client code.

Related to T2400
Related to D6750

Depends on D6752

Diff Detail

Repository
rDMOD Data model
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 25399
Build 39705: Phabricator diff pipeline on jenkinsJenkins console · Jenkins
Build 39704: arc lint + arc unit

Event Timeline

anlambert created this revision.Dec 6 2021, 5:43 PM
Herald added a reviewer: Reviewers. · View Herald TranscriptDec 6 2021, 5:43 PM
swh-public-ci added a comment.Dec 6 2021, 5:44 PM

Build has FAILED

Patch application report for D6755 (id=24523)

Could not rebase; Attempt merge onto 8d96dfedee...

Updating 8d96dfe..2e482c1
Fast-forward
 swh/model/hashutil.py            |   2 +-
 swh/model/tests/test_hashutil.py | 464 ++++++++++++++++++++++-----------------
 2 files changed, 261 insertions(+), 205 deletions(-)
Changes applied before test
commit 2e482c196deb2880b85673e5218f9570d61271b4
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 6 17:38:59 2021 +0100

    hashutil: Add support for md5 sum
    
    Enable to compute md5 sum through the hashutil.MultiHash class.
    
    Nevertheless, md5 is not put in DEFAULT_ALGORITHMS set and must
    be explicitely requested by client code.
    
    Related to T2400

commit 4a53fdcae885fdfb235c6b5df139e630ad088fc4
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 6 16:02:58 2021 +0100

    test_hashutil: Port tests from unittest to pytest

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/408/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/408/console

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 6 2021, 5:44 PM
Harbormaster failed remote builds in B25397: Diff 24523!
anlambert mentioned this in D6750: debian: Add md5 sum fallback when sha* checksum is missing in metadata.Dec 6 2021, 5:44 PM
swh-public-ci added a comment.Dec 6 2021, 5:46 PM

Build is green

Patch application report for D6755 (id=24523)

Could not rebase; Attempt merge onto 8d96dfedee...

Updating 8d96dfe..2e482c1
Fast-forward
 swh/model/hashutil.py            |   2 +-
 swh/model/tests/test_hashutil.py | 464 ++++++++++++++++++++++-----------------
 2 files changed, 261 insertions(+), 205 deletions(-)
Changes applied before test
commit 2e482c196deb2880b85673e5218f9570d61271b4
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 6 17:38:59 2021 +0100

    hashutil: Add support for md5 sum
    
    Enable to compute md5 sum through the hashutil.MultiHash class.
    
    Nevertheless, md5 is not put in DEFAULT_ALGORITHMS set and must
    be explicitely requested by client code.
    
    Related to T2400

commit 4a53fdcae885fdfb235c6b5df139e630ad088fc4
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 6 16:02:58 2021 +0100

    test_hashutil: Port tests from unittest to pytest

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/409/ for more details.

Harbormaster completed remote builds in B25397: Diff 24523.Dec 6 2021, 5:46 PM
anlambert requested review of this revision.Dec 6 2021, 5:46 PM
ardumont accepted this revision.Dec 6 2021, 5:50 PM
This revision is now accepted and ready to land.Dec 6 2021, 5:50 PM
anlambert updated this revision to Diff 24525.Dec 6 2021, 7:29 PM

Rebase

swh-public-ci added a comment.Dec 6 2021, 7:30 PM

Build has FAILED

Patch application report for D6755 (id=24525)

Could not rebase; Attempt merge onto 8d96dfedee...

Updating 8d96dfe..37364c2
Fast-forward
 swh/model/hashutil.py            |   2 +-
 swh/model/tests/test_hashutil.py | 466 ++++++++++++++++++++++-----------------
 2 files changed, 263 insertions(+), 205 deletions(-)
Changes applied before test
commit 37364c24b50911f107cfde7b3a283dd52e1a76c9
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 6 17:38:59 2021 +0100

    hashutil: Add support for md5 sum
    
    Enable to compute md5 sum through the hashutil.MultiHash class.
    
    Nevertheless, md5 is not put in DEFAULT_ALGORITHMS set and must
    be explicitely requested by client code.
    
    Related to T2400

commit 243520daa82790ba05e8e88feea3065e905c03db
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 6 16:02:58 2021 +0100

    test_hashutil: Port tests from unittest to pytest

Link to build: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/411/
See console output for more information: https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/411/console

Harbormaster failed remote builds in B25399: Diff 24525!Dec 6 2021, 7:30 PM
swh-public-ci added a comment.Dec 6 2021, 7:33 PM

Build is green

Patch application report for D6755 (id=24525)

Could not rebase; Attempt merge onto 8d96dfedee...

Updating 8d96dfe..37364c2
Fast-forward
 swh/model/hashutil.py            |   2 +-
 swh/model/tests/test_hashutil.py | 466 ++++++++++++++++++++++-----------------
 2 files changed, 263 insertions(+), 205 deletions(-)
Changes applied before test
commit 37364c24b50911f107cfde7b3a283dd52e1a76c9
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 6 17:38:59 2021 +0100

    hashutil: Add support for md5 sum
    
    Enable to compute md5 sum through the hashutil.MultiHash class.
    
    Nevertheless, md5 is not put in DEFAULT_ALGORITHMS set and must
    be explicitely requested by client code.
    
    Related to T2400

commit 243520daa82790ba05e8e88feea3065e905c03db
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Mon Dec 6 16:02:58 2021 +0100

    test_hashutil: Port tests from unittest to pytest

See https://jenkins.softwareheritage.org/job/DMOD/job/tests-on-diff/412/ for more details.

Harbormaster completed remote builds in B25399: Diff 24525.Dec 6 2021, 7:33 PM
Closed by commit rDMOD37364c24b509: hashutil: Add support for md5 sum (authored by anlambert). · Explain WhyDec 6 2021, 7:36 PM
This revision was automatically updated to reflect the committed changes.
anlambert added a commit: rDMOD37364c24b509: hashutil: Add support for md5 sum.

Revision Contents
Changeset List

PathSizeCoverage (All)Coverage (Touched)
swh/
model/
2 lines90%
Loading...
tests/
34 lines94%
Loading...

Diff 24525

View Options

swh/model/hashutil.py

Loading...
View Options

swh/model/tests/test_hashutil.py

Loading...
About · Developer information · Legal