Differential D6698

ra: Persist path executable flag in FileState when replaying revisions
ClosedPublic
Actions

Authored by anlambert on Nov 26 2021, 5:08 PM.

Details

Reviewers

ardumont

Group Reviewers

Reviewers

Maniphest Tasks

T3695: Investigate revision reconstruction discrepancy with subversion export

Commits

rDLDSVN4bae0f9315d8: ra: Persist path executable flag in FileState when replaying revisions

Summary

When a file is marked as executable through the use of the svn:executable
property, that info must be persisted across replayed revisions.

Indeed, such a file can also be a svn link but when it is turned back to a
regular file (by unsetting svn:special property and modifying its content)
the execution rights should also be set on it as with a subversion export.

Without persisting the executable info, the execution rights will not be
restored when such a case appears.

Related to T3695

Diff Detail

Repository

rDLDSVN Subversion (SVN) loader

Branch

svn-executable-property-on-link-handling-bugfix

Lint

No Linters Available

Unit

No Unit Test Coverage

Build Status

Buildable 25206
Build 39387: Phabricator diff pipeline on jenkins	Jenkins console · Jenkins
Build 39386: arc lint + arc unit

Event Timeline

anlambert created this revision.Nov 26 2021, 5:08 PM

Herald added a reviewer: Reviewers. · View Herald TranscriptNov 26 2021, 5:08 PM

Build is green

Patch application report for D6698 (id=24332)

Rebasing onto ed3c0c986b...

Current branch diff-target is up to date.

Changes applied before test

commit 4bae0f9315d8f49d19e7c2389005ab6544bcacc5
Author: Antoine Lambert <anlambert@softwareheritage.org>
Date:   Fri Nov 26 16:59:52 2021 +0100

    ra: Persist path executable flag in FileState when replaying revisions
    
    When a file is marked as executable through the use of the svn:executable
    property, that info must be persisted across replayed revisions.
    
    Indeed, such a file can also be a svn link but when it is turned back to a
    regular file (by unsetting svn:special property and modifying its content)
    the execution rights should also be set on it as with a subversion export.
    
    Without persisting the executable info, the execution rights will not be
    restored when such a case appears.
    
    Related to T3695

See https://jenkins.softwareheritage.org/job/DLDSVN/job/tests-on-diff/203/ for more details.

Harbormaster completed remote builds in B25206: Diff 24332.Nov 26 2021, 5:10 PM

anlambert requested review of this revision.Nov 26 2021, 5:10 PM